From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Theodore Tso <tedtso@gmail.com>, Theodore Tso <tytso@mit.edu>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] tracing: reduce latency and remove percpu trace_seq
Date: Mon, 07 Jun 2010 15:50:22 +0800 [thread overview]
Message-ID: <4C0CA4BE.9000703@cn.fujitsu.com> (raw)
In-Reply-To: <1275620590.15884.70.camel@gandalf.stny.rr.com>
Steven Rostedt wrote:
> On Fri, 2010-06-04 at 10:23 +0800, Lai Jiangshan wrote:
>> Steven Rostedt wrote:
>>
>>> The "print" in the trace_seq_printf() is the TP_printk() field of the
>>> TRACE_EVENT. I believe that there were some events (ext4?) that did
>>> things that required preemption disabled.
>>>
>> It seems that ext4 has no such events.
>> I find jbd2_dev_to_name() in the TP_printk() field of ext4's tracepoints.
>> And it seems that jbd2_dev_to_name() requires preemption enabled and sleepable.
>>
>> Maybe there were some events did things that required preemption disabled.
>> But No document ensure TP_printk() preemption disabled, such events should
>> be fixed, I think.
>
> Well, I had a private email conversation with Ted last year where IIRC,
> adding the preempt disable would fix things.
>
> I'd like to make sure Ted is OK with removing that before we do so.
>
> Ted?
>
Hi, Ted
Could you give some comments?
I'm waiting and will appreciate your help.
Thanx, Lai
next prev parent reply other threads:[~2010-06-07 7:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 10:26 Lai Jiangshan
2010-06-03 13:36 ` Steven Rostedt
2010-06-04 2:23 ` Lai Jiangshan
2010-06-04 3:03 ` Steven Rostedt
2010-06-07 7:50 ` Lai Jiangshan [this message]
2010-07-21 2:03 ` Steven Rostedt
2010-07-23 12:10 ` [tip:perf/core] tracing: Reduce " tip-bot for Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0CA4BE.9000703@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tedtso@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome