From: Alan Ott <alan@signal11.us>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] HID: Documentation for hidraw
Date: Fri, 18 Jun 2010 09:37:57 -0400 [thread overview]
Message-ID: <4C1B76B5.10806@signal11.us> (raw)
In-Reply-To: <20100618115738.c3dfb81b.ospite@studenti.unina.it>
On 06/18/2010 05:57 AM, Antonio Ospite wrote:
>
> Maybe both hidraw.txt and hiddev.txt can be moved to
> Documentation/hid/?
>
>
Antonio,
You and Jiri seem to have the same idea on this one. Sounds good to me.
>> +
>> +HIDIOCGRAWNAME(len): Get Raw Name
>> +This ioctl returns a string containing the vendor and product strings of
>> +the device. The returned string is Unicode, UTF-8 encoded.
>> +
>>
> Is the encoding specified in the HID spec?
>
USB returns strings to the host as Unicode, UTF16LE encoded. The kernel
converts them to UTF-8. See usb_string() in drivers/usb/core/message.c.
>
> Just a very minimal remark, maybe the code should follow the kernel
> coding style (early return on error, no braces for one line conditional
> blocks) even if it is a userspace application. Being it in the
> kernel Documentation I assume people reading it would be used to kernel
> style more.
>
>
Good point. I'll run the style check on it and fix it up.
Alan.
next prev parent reply other threads:[~2010-06-18 13:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 3:38 Alan Ott
2010-06-18 9:57 ` Antonio Ospite
2010-06-18 13:37 ` Alan Ott [this message]
2010-06-18 11:59 ` Jiri Kosina
2010-06-18 14:45 ` Alan Ott
2010-06-18 15:45 ` Randy Dunlap
2010-06-19 2:13 ` [PATCH v2 0/2] HID: hidraw documentation Alan Ott
2010-06-19 3:14 ` Randy Dunlap
2010-06-19 17:47 ` Jiri Kosina
2010-06-19 8:25 ` Antonio Ospite
2010-06-19 2:13 ` [PATCH v2 1/2] HID: Documentation for hidraw Alan Ott
2010-06-19 2:13 ` [PATCH v2 2/2] HID: Move hiddev.txt to the new Documentation/HID directory Alan Ott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1B76B5.10806@signal11.us \
--to=alan@signal11.us \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ospite@studenti.unina.it \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®