From: Mike Rapoport <mike@compulab.co.il>
To: Colin Cross <ccross@android.com>
Cc: Kulikov Vasiliy <segooon@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Erik Gilling <konkers@android.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] arm/mach-tegra: fix unsigned calcs
Date: Tue, 20 Jul 2010 10:53:56 +0300 [thread overview]
Message-ID: <4C455614.1000801@compulab.co.il> (raw)
In-Reply-To: <AANLkTinFKH4Ed3UW3kMKdT5RJwmmE5n5k7nO01mB9xpO@mail.gmail.com>
Colin Cross wrote:
> On Thu, Jul 15, 2010 at 11:43 AM, Kulikov Vasiliy <segooon@gmail.com> wrote:
>> divider_u71 is unsigned, so this check is buggy:
>> if (divider_u71 - 2 > 255 || divider_u71 - 2 < 0)
>>
>> If divider_u71 is 0 or 1 both checks are lying.
>> So, it does not produce a buggy answer, but it is confusing.
>
> Hi Kulikov,
The first name is Vasiliy :)
> Thanks for the patch. This problem has been fixed in another patch in
> the linux-tegra tree, I'll post it for review and update the
> linux-next tree soon.
>
> Colin Cross
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2010-07-20 7:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 18:43 Kulikov Vasiliy
2010-07-20 7:14 ` Colin Cross
2010-07-20 7:53 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C455614.1000801@compulab.co.il \
--to=mike@compulab.co.il \
--cc=ccross@android.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=konkers@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome