From: Prarit Bhargava <prarit@redhat.com>
To: Xiaotian Feng <dfeng@redhat.com>
Cc: cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org,
Dave Jones <davej@redhat.com>, Thomas Renninger <trenn@suse.de>
Subject: Re: [PATCH] cpufreq: fix memory leak in cpufreq_add_dev
Date: Tue, 20 Jul 2010 08:55:13 -0400 [thread overview]
Message-ID: <4C459CB1.8060800@redhat.com> (raw)
In-Reply-To: <1279627862-4107-1-git-send-email-dfeng@redhat.com>
On 07/20/2010 08:11 AM, Xiaotian Feng wrote:
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 063b218..12263b4 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1077,6 +1077,7 @@ err_out_unregister:
>
> err_unlock_policy:
> unlock_policy_rwsem_write(cpu);
> + free_cpumask_var(policy->related_cpus);
> err_free_cpumask:
> free_cpumask_var(policy->cpus);
> err_free_policy:
>
Seems right to me ...
P.
prev parent reply other threads:[~2010-07-20 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 12:11 Xiaotian Feng
2010-07-20 12:55 ` Prarit Bhargava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C459CB1.8060800@redhat.com \
--to=prarit@redhat.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=dfeng@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome