Re: [PATCH rfc] firewire: add isochronous multichannel reception

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Stefan Richter wrote:
>  static int ohci_queue_iso(struct fw_iso_context *base,
>  			  struct fw_iso_packet *packet,
>  			  struct fw_iso_buffer *buffer,
> @@ -2587,14 +2761,17 @@ static int ohci_queue_iso(struct fw_iso_
>  {
>  	struct iso_context *ctx = container_of(base, struct iso_context, base);
>  	unsigned long flags;
> -	int ret;
> +	int ret = -ENOSYS;
>  
>  	spin_lock_irqsave(&ctx->context.ohci->lock, flags);
> -	if (base->type == FW_ISO_CONTEXT_TRANSMIT)
> -		ret = ohci_queue_iso_transmit(base, packet, buffer, payload);
> -	else
> -		ret = ohci_queue_iso_receive_packet_per_buffer(base, packet,
> -							buffer, payload);
> +	switch (base->type) {
> +	case FW_ISO_CONTEXT_TRANSMIT:
> +		ret = queue_iso_transmit(base, packet, buffer, payload);
> +	case FW_ISO_CONTEXT_RECEIVE:
> +		ret = queue_iso_packet_per_buffer(base, packet, buffer, payload);
> +	case FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL:
> +		ret = queue_iso_buffer_fill(base, packet, buffer, payload);
> +	}
>  	spin_unlock_irqrestore(&ctx->context.ohci->lock, flags);
>  
>  	return ret;

Where is the brown paper bag...
There should be break; at each case.  Updated patch is at
http://user.in-berlin.de/~s5r6/linux1394/pending/1171-firewire-add-isochronous-multichannel-reception.patch
-- 
Stefan Richter
-=====-==-=- -=== ===-=
http://arcgraph.de/sr/