mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, h.mitake@gmail.com,
	Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jason Baron <jbaron@redhat.com>,
	Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH RFC] perf lock: Add new event "lock_acquired_waittime" for contention analysis
Date: Tue, 03 Aug 2010 16:37:16 +0900	[thread overview]
Message-ID: <4C57C72C.3070902@dcl.info.waseda.ac.jp> (raw)
In-Reply-To: <1280751784.1923.146.camel@laptop>

On 08/02/10 21:23, Peter Zijlstra wrote:
> On Sun, 2010-08-01 at 14:36 +0900, Hitoshi Mitake wrote:
>> I want to make lockdep production kernel feature with dynamic
>> patching.
>
> Not really feasible. Note that enabling lockdep grows the size of
> spinlock_t (and others) quite significantly.
>
> Then there is the problem that you need to pass all tasks through some
> quiesent state in order to enable lockdep (there must be a guarantee of
> no locks held).
>
> Now, we could possibly make it all work, but I'm not at all convinced we
> want to pay the price, which is a much _much_ more complex
> infrastructure.
>
>

I have to agree with the problem of huge cost you mentioned above.

But, I believe that
  - lock validation
  - lock tracing
  - in kernel light weight lock usage statistics
should be divided into individual features, at least.
And tracing and statistics should be available for production kernel, 
ideally.

How do you think about this point?

  reply	other threads:[~2010-08-03  7:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24 16:55 Hitoshi Mitake
2010-07-28 16:39 ` Frederic Weisbecker
2010-08-01  5:36   ` Hitoshi Mitake
2010-08-01  7:56     ` Hitoshi Mitake
2010-08-02 12:23     ` Peter Zijlstra
2010-08-03  7:37       ` Hitoshi Mitake [this message]
2010-08-03  8:00         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C57C72C.3070902@dcl.info.waseda.ac.jp \
    --to=mitake@dcl.info.waseda.ac.jp \
    --cc=acme@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=fweisbec@gmail.com \
    --cc=h.mitake@gmail.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=xiaoguangrong@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®