From: Tejun Heo <tj@kernel.org>
To: Will Drewry <wad@chromium.org>
Cc: linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
Jens Axboe <axboe@kernel.dk>, Karel Zak <kzak@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>, Jan Blunck <jblunck@suse.de>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH v2 2/3] genhd, efi: add efi partition metadata to hd_structs
Date: Wed, 04 Aug 2010 09:59:08 +0200 [thread overview]
Message-ID: <4C591DCC.7080104@kernel.org> (raw)
In-Reply-To: <1280887483-2979-2-git-send-email-wad@chromium.org>
Hello,
On 08/04/2010 04:04 AM, Will Drewry wrote:
> struct partition_meta_info {
> enum partition_meta_info_format_t format;
> union {
> +#ifdef CONFIG_EFI_PARTITION
> + struct {
> + efi_guid_t uuid;
> + efi_guid_t type;
> + efi_char16_t label[72 / sizeof(efi_char16_t)];
> + } efi;
> +#endif
It would be nice if uuid can be made a common field outside of the
union so that generic code which only cares about UUID can simply read
it off.
Thanks.
--
tejun
next prev parent reply other threads:[~2010-08-04 7:59 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 19:17 [PATCH RFC] efi: add and expose efi_partition_by_guid Will Drewry
2010-08-02 23:00 ` David Miller
2010-08-03 2:44 ` Will Drewry
2010-08-03 2:52 ` [PATCH v2 " Will Drewry
2010-08-03 18:50 ` Randy Dunlap
2010-08-03 18:52 ` Will Drewry
2010-08-03 2:48 ` [PATCH RFC (alt)] efi: add efi_partition_walk and expose for kernel access Will Drewry
2010-08-03 16:08 ` [PATCH RFC] efi: add and expose efi_partition_by_guid Tejun Heo
2010-08-03 17:17 ` Kay Sievers
2010-08-03 17:55 ` Will Drewry
2010-08-03 18:23 ` Kay Sievers
2010-08-03 18:52 ` Will Drewry
2010-08-03 21:35 ` [PATCH 1/2] block, partition: add partition_meta_info to hd_struct Will Drewry
2010-08-03 21:35 ` [PATCH 2/2] genhd, efi: add efi partition metadata to hd_structs Will Drewry
2010-08-03 21:54 ` Kay Sievers
2010-08-03 22:27 ` Will Drewry
2010-08-03 23:13 ` Kay Sievers
2010-08-04 2:04 ` [PATCH v2 1/3] block, partition: add partition_meta_info to hd_struct Will Drewry
2010-08-04 7:57 ` Tejun Heo
2010-08-04 14:46 ` Will Drewry
2010-08-04 2:04 ` [PATCH v2 2/3] genhd, efi: add efi partition metadata to hd_structs Will Drewry
2010-08-04 7:59 ` Tejun Heo [this message]
2010-08-04 9:00 ` Karel Zak
2010-08-04 10:14 ` Kay Sievers
2010-08-04 14:44 ` Will Drewry
2010-08-04 15:28 ` Kay Sievers
2010-08-04 15:56 ` Will Drewry
2010-08-04 18:22 ` [PATCH v3 1/3] block, partition: add partition_meta_info to hd_struct Will Drewry
2010-08-04 18:22 ` [PATCH v3 2/3] genhd, efi: add efi partition metadata to hd_structs Will Drewry
2010-08-04 18:22 ` [PATCH v3 3/3] init: add support for root devices specified by partition UUID Will Drewry
2010-08-05 10:55 ` Tejun Heo
2010-08-05 14:26 ` Will Drewry
2010-08-05 14:29 ` Tejun Heo
2010-08-05 19:19 ` Will Drewry
2010-08-05 19:29 ` Kay Sievers
2010-08-31 20:47 ` [PATCH v4 1/3] block, partition: add partition_meta_info to hd_struct Will Drewry
2010-09-15 14:22 ` Jens Axboe
2010-08-31 20:47 ` [PATCH v4 2/3] genhd, efi: add efi partition metadata to hd_structs Will Drewry
2010-08-31 20:47 ` [PATCH v4 3/3] init: add support for root devices specified by partition UUID Will Drewry
2010-08-04 14:44 ` [PATCH v2 2/3] genhd, efi: add efi partition metadata to hd_structs Will Drewry
2010-08-04 2:04 ` [PATCH 3/3] init: add support for root devices specified by partition UUID Will Drewry
2010-08-04 14:27 ` [PATCH 2/2] genhd, efi: add efi partition metadata to hd_structs John Stoffel
2010-08-04 14:45 ` Will Drewry
2010-08-04 15:25 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C591DCC.7080104@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=jblunck@suse.de \
--cc=joe@perches.com \
--cc=kay.sievers@vrfy.org \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome