From: Mike Rapoport <mike@compulab.co.il>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator_remove()
Date: Tue, 10 Aug 2010 18:32:11 +0300 [thread overview]
Message-ID: <4C6170FB.9080609@compulab.co.il> (raw)
In-Reply-To: <20100810150052.GK6416@rakim.wolfsonmicro.main>
Mark Brown wrote:
> On Mon, Aug 09, 2010 at 03:58:06PM +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Mike Rapoport <mike@compulab.co.il>
>
>>
>> - platform_set_drvdata(pdev, ri);
>> + platform_set_drvdata(pdev, rdev);
>>
>
> This would've been easier to review if you'd mentioned in the changelog
> that there were no users of the current platform data, just to show that
> you'd checked.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2010-08-10 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 7:58 Axel Lin
2010-08-10 15:00 ` Mark Brown
2010-08-10 15:32 ` Mike Rapoport [this message]
2010-08-10 17:18 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6170FB.9080609@compulab.co.il \
--to=mike@compulab.co.il \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome