On 08/07/2010 04:50 AM, Dan Carpenter wrote: > If we have a ns name without a following profile then in the original > code it did "*ns_name = &name[1];". "name" is NULL so "*ns_name" is > 0x1. That isn't useful and could cause an oops when this function is > called from aa_remove_profiles(). > > Signed-off-by: Dan Carpenter Indeed. I am sorry to say this case was not enabled in the test suite :( However proposed patch is incorrect, in that it results in namespace name that starts at &name[1]. I've attached two patches, the first fixes this issue, and the second fixes a locking bug in namespace removal, for this case (ie. where there is no profile name specified. Thanks for catching this John