From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firewire: sbp2: fix stall with "Unsolicited response"
Date: Mon, 16 Aug 2010 23:21:42 +0200 [thread overview]
Message-ID: <4C69ABE6.6030309@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.d1f4cde2efe6d756@s5r6.in-berlin.de>
Stefan Richter wrote:
> The stalls happen during heavy or moderate disk traffic in periods that
> are a multiple of 5 minutes, roughly twice per hour. They are caused
> by the target responding too late to an ORB_Pointer register write
[and subsequent SCSI error handling.]
> So let's just ignore RCODE_CANCELLED in the transaction callback and
> wait for the target to complete the ORB nevertheless.
PS: This is not only about the stalls. It is also to prevent memory
corruption that may happen when the target writes to SCSI request
buffers after they were unmapped and freed, although this does not
appear likely to me.
--
Stefan Richter
-=====-==-=- =--- =----
http://arcgraph.de/sr/
prev parent reply other threads:[~2010-08-16 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 19:58 [PATCH 1/2] firewire: sbp2: fix memory leak in sbp2_cancel_orbs or at send error Stefan Richter
2010-08-16 20:13 ` [PATCH 2/2] firewire: sbp2: fix stall with "Unsolicited response" Stefan Richter
2010-08-16 21:21 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C69ABE6.6030309@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®