From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Alan Ott <alan@signal11.us>
Cc: Jiri Kosina <jkosina@suse.cz>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@suse.de>,
Marcel Holtmann <marcel@holtmann.org>,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usbhid: Set Report ID properly for Output reports on the Control endpoint.
Date: Wed, 25 Aug 2010 13:48:06 +0400 [thread overview]
Message-ID: <4C74E6D6.6040203@ru.mvista.com> (raw)
In-Reply-To: <1282020244-25786-1-git-send-email-alan@signal11.us>
Hello.
Alan Ott wrote:
> When I made commit 29129a98e6fc89, I didn't account for *buf not being
> the report ID anymore, as buf is incremented.
> This applies to 2.6.35 and newer.
> Signed-off-by: Alan Ott <alan@signal11.us>
[...]
> diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
> index b729c02..ffd6899 100644
> --- a/drivers/hid/usbhid/hid-core.c
> +++ b/drivers/hid/usbhid/hid-core.c
> @@ -828,6 +828,7 @@ static int usbhid_output_raw_report(struct hid_device *hid, __u8 *buf, size_t co
> }
> } else {
> int skipped_report_id = 0;
> + int report_id = buf[0];
Please keep the empty line after the declaration block.
> if (buf[0] == 0x0) {
> /* Don't send the Report ID */
> buf++;
WBR, Sergei
prev parent reply other threads:[~2010-08-25 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 4:44 Alan Ott
2010-08-24 15:49 ` Jiri Kosina
2010-08-25 9:48 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C74E6D6.6040203@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=alan@signal11.us \
--cc=gregkh@suse.de \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®