mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Johansen <john.johansen@canonical.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: James Morris <jmorris@namei.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: Comments to apparmor Makefile (and security/Makefile)
Date: Sat, 28 Aug 2010 13:32:51 -0700	[thread overview]
Message-ID: <4C797273.2030601@canonical.com> (raw)
In-Reply-To: <20100828192155.GA9287@merkur.ravnborg.org>

On 08/28/2010 12:21 PM, Sam Ravnborg wrote:
>>
>>> 8) From security/Makefile:
>>>
>>>     obj-$(CONFIG_SECURITY_APPARMOR)         += apparmor/built-in.o
>>> This is _not_ how we do it.
>>>
>>> We say just:
>>>
>>>     obj-$(CONFIG_SECURITY_APPARMOR)         += apparmor/
>>>
>>> [security/Makefile has this issue in several places]
>>>
>> okay, I set it up this way to conform to other entries in the file
>> If we are going to fix apparmor's entry we should fix them all
> 
> Agreed - its better to fix them all in one go.
> I assume you do this in a follow-up patch - it is straightforward.
> 

Yes, I was planning to submit as a separate patch.

thanks
john

      reply	other threads:[~2010-08-28 20:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-28  7:03 Sam Ravnborg
2010-08-28 19:11 ` John Johansen
2010-08-28 19:21   ` Sam Ravnborg
2010-08-28 20:32     ` John Johansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C797273.2030601@canonical.com \
    --to=john.johansen@canonical.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome