From: "Jan Beulich" <JBeulich@novell.com>
To: "Chen Gong" <gong.chen@linux.intel.com>
Cc: <khali@linux-fr.org>, <lm-sensors@lm-sensors.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH] x86/hwmon: {core,pkg,via-cpu}temp_device_remove() can all be __cpuinit
Date: Tue, 14 Sep 2010 08:35:39 +0100 [thread overview]
Message-ID: <4C8F41EB0200007800015E8D@vpn.id2.novell.com> (raw)
In-Reply-To: <4C8F2317.60506@linux.intel.com>
>>> On 14.09.10 at 09:24, Chen Gong <gong.chen@linux.intel.com> wrote:
> 于 9/13/2010 6:30 PM, Jan Beulich 写道:
>> ... as they're being called only from a __cpuinit function.
>>
>> Signed-off-by: Jan Beulich<jbeulich@novell.com>
>>
>> ---
>> drivers/hwmon/coretemp.c | 2 +-
>> drivers/hwmon/pkgtemp.c | 2 +-
>> drivers/hwmon/via-cputemp.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> --- linux-2.6.36-rc4/drivers/hwmon/coretemp.c 2010-09-13 08:45:02.000000000
> +0200
>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/coretemp.c 2010-09-03
> 17:54:14.000000000 +0200
>> @@ -480,7 +480,7 @@ exit:
>> return err;
>> }
>>
>> -static void coretemp_device_remove(unsigned int cpu)
>> +static void __cpuinit coretemp_device_remove(unsigned int cpu)
>> {
>> struct pdev_entry *p, *n;
>> mutex_lock(&pdev_list_mutex);
>> --- linux-2.6.36-rc4/drivers/hwmon/pkgtemp.c 2010-09-13 08:45:03.000000000
> +0200
>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/pkgtemp.c 2010-09-01
> 09:00:45.000000000 +0200
>> @@ -337,7 +337,7 @@ exit:
>> }
>>
>> #ifdef CONFIG_HOTPLUG_CPU
>> -static void pkgtemp_device_remove(unsigned int cpu)
>> +static void __cpuinit pkgtemp_device_remove(unsigned int cpu)
>> {
>> struct pdev_entry *p, *n;
>> unsigned int i;
>> --- linux-2.6.36-rc4/drivers/hwmon/via-cputemp.c 2010-09-13
> 08:45:03.000000000 +0200
>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/via-cputemp.c 2010-09-13
> 00:00:00.000000000 +0200
>> @@ -238,7 +238,7 @@ exit:
>> }
>>
>> #ifdef CONFIG_HOTPLUG_CPU
>> -static void via_cputemp_device_remove(unsigned int cpu)
>> +static void __cpuinit via_cputemp_device_remove(unsigned int cpu)
>> {
>> struct pdev_entry *p, *n;
>> mutex_lock(&pdev_list_mutex);
>>
>>
>>
>>
>
> I think the change in the coretemp.c is needed but other 2 are
> unnecessary because CONFIG_HOTPLUG_CPU has covered the codes final
> status after init done.
Perhaps you're right, but (just like was done for coretemp) these
CONFIG_HOTPLUG_CPU conditionals are really superfluous and should
go away.
Jan
next prev parent reply other threads:[~2010-09-14 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 10:30 Jan Beulich
2010-09-14 7:24 ` [lm-sensors] [PATCH] x86/hwmon: {core, pkg, via-cpu}temp_device_remove() " Chen Gong
2010-09-14 7:35 ` Jan Beulich [this message]
2010-09-14 7:46 ` Chen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8F41EB0200007800015E8D@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=gong.chen@linux.intel.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®