Re: [PATCH] SCSI: fix qla4xxx build on PPC

[Jiri Slaby <jslaby@suse.cz>]

On 09/14/2010 02:12 PM, Jiri Slaby wrote:
> We use read/write[bslq] but do not include linux/io.h. This causes
> build failures on PPC. Include that file.

Just in case you want to include the failure:
drivers/scsi/qla4xxx/ql4_nx.c: In function 'qla4_8xxx_pci_mem_read_direct':
drivers/scsi/qla4xxx/ql4_nx.c:716:3: error: implicit declaration of
function 'readq'
drivers/scsi/qla4xxx/ql4_nx.c: In function 'qla4_8xxx_pci_mem_write_direct':
drivers/scsi/qla4xxx/ql4_nx.c:787:3: error: implicit declaration of
function 'writeq'

> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Ravi Anand <ravi.anand@qlogic.com>
> Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
> ---
>  drivers/scsi/qla4xxx/ql4_nx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
> index 5d4a382..449256f 100644
> --- a/drivers/scsi/qla4xxx/ql4_nx.c
> +++ b/drivers/scsi/qla4xxx/ql4_nx.c
> @@ -5,6 +5,7 @@
>   * See LICENSE.qla4xxx for copyright and licensing details.
>   */
>  #include <linux/delay.h>
> +#include <linux/io.h>
>  #include <linux/pci.h>
>  #include "ql4_def.h"
>  #include "ql4_glbl.h"

thanks,
-- 
js
suse labs