mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Namhyung Kim <namhyung@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: fix an address space warning in blk-map.c
Date: Wed, 15 Sep 2010 13:07:12 +0200	[thread overview]
Message-ID: <4C90A8E0.4050807@kernel.dk> (raw)
In-Reply-To: <1284478956-13664-1-git-send-email-namhyung@gmail.com>

On 2010-09-14 17:42, Namhyung Kim wrote:
> Change type of 2nd parameter of blk_rq_aligned() into unsigned long
> and remove unnecessary casting. Now we can call it with 'uaddr'
> instead of 'ubuf' in __blk_rq_map_user() so that it can remove
> following warnings from sparse:
> 
>  block/blk-map.c:57:31: warning: incorrect type in argument 2 (different address spaces)
>  block/blk-map.c:57:31:    expected void *addr
>  block/blk-map.c:57:31:    got void [noderef] <asn:1>*ubuf
> 
> However blk_rq_map_kern() needs one more local variable to handle it.

Thanks, applied to for-2.6.37/core

-- 
Jens Axboe


      reply	other threads:[~2010-09-15 11:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-14 15:42 Namhyung Kim
2010-09-15 11:07 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C90A8E0.4050807@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome