From: Wolfgang Grandegger <wg@grandegger.com>
To: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
arjan@linux.intel.com,
Tomoya MORINAGA <morinaga526@dsn.okisemi.com>,
yong.y.wang@intel.com, gregkh@suse.de, qi.wang@intel.com,
andrew.chih.howe.khor@intel.com, meego-dev@meego.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
socketcan-core@lists.berlios.de,
Samuel Ortiz <sameo@linux.intel.com>,
Barry Song <21cnbao@gmail.com>,
Christian Pellegrin <chripell@fsfe.org>,
Wolfram Sang <w.sang@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35
Date: Thu, 16 Sep 2010 11:10:56 +0200 [thread overview]
Message-ID: <4C91DF20.7040807@grandegger.com> (raw)
In-Reply-To: <002601cb557c$69292180$66f8800a@maildom.okisemi.com>
On 09/16/2010 10:51 AM, Masayuki Ohtake wrote:
> Hi Marc,
>
>> - Please remove rx-filter handling from the driver completely, simply
>> receive every can frame
>
> This rx-filter function is for Topcliff's CAN HW function.
> This function is important.
> Could you tell us the reason why should we remove filter function ?
We do not (yet) support the filtering capability of the CAN controller
hardware. Therefore please configure the hardware filter to accept *any*
CAN message like all other drivers do, e.g.:
http://lxr.linux.no/#linux+v2.6.35.4/drivers/net/can/sja1000/sja1000.c#L249
Wolfgang.
next prev parent reply other threads:[~2010-09-16 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 12:22 Masayuki Ohtak
2010-09-13 15:14 ` Marc Kleine-Budde
2010-09-16 8:51 ` Masayuki Ohtake
2010-09-16 9:10 ` Wolfgang Grandegger [this message]
2010-09-16 23:55 ` Masayuki Ohtake
2010-09-13 18:47 ` Daniel Baluta
2010-09-15 7:36 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C91DF20.7040807@grandegger.com \
--to=wg@grandegger.com \
--cc=21cnbao@gmail.com \
--cc=andrew.chih.howe.khor@intel.com \
--cc=arjan@linux.intel.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=masa-korg@dsn.okisemi.com \
--cc=meego-dev@meego.com \
--cc=mkl@pengutronix.de \
--cc=morinaga526@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=w.sang@pengutronix.de \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome