From: Dzianis Kahanovich <mahatma@bspu.unibel.by>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: Re: i2c: Re: #2 (Re: More modaliases + patchtool))
Date: Fri, 17 Sep 2010 18:47:41 +0300 [thread overview]
Message-ID: <4C938D9D.4070709@bspu.unibel.by> (raw)
In-Reply-To: <20100917140647.GA18367@opensource.wolfsonmicro.com>
Mark Brown пишет:
>> + 1 attach for "next" branch.
>
> Again, please try to follow the process in SubmittingPatches for sending
> patches.
One thing (patch) per message?
Yes, I just speculate in this point on fact there are same patch for "next"
branch and may be intrpreted as one ;). Sorry.
>> --- linux-2.6.36-rc4-git3/sound/soc/codecs/tlv320dac33.c 2010-09-17 12:30:31.000000000 +0300
>> +++ b/sound/soc/codecs/tlv320dac33.c 2010-09-17 12:39:07.801200070 +0300
>> @@ -1712,6 +1712,9 @@ static int __init dac33_module_init(void
>> }
>> return 0;
>> }
>> +
>> +MODULE_DEVICE_TABLE(i2c, tlv320dac33_i2c_id);
>> +
>
> This change is OK but should be moved next to the actual table.
This means - after:
static const struct i2c_device_id tlv320dac33_i2c_id[] = {
...
}
?
IMHO I just copyed style of some of (now not remember) module example in
script. OK.
Thanks, next time I will carry out your recomendations. But may be not in
script (2) - current way most simple and safe.
--
WBR, Dzianis Kahanovich AKA Denis Kaganovich, http://mahatma.bspu.unibel.by/
next prev parent reply other threads:[~2010-09-17 15:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C6BE292.3060307@bspu.unibel.by>
2010-08-19 0:50 ` More modaliases + patchtool Rusty Russell
2010-08-19 14:58 ` #3 (Re: More modaliases + patchtool) Dzianis Kahanovich
[not found] ` <4C6D26BC.9040805@bspu.unibel.by>
2010-09-11 2:14 ` #2 " Rusty Russell
2010-09-11 3:36 ` Jeremy Fitzhardinge
2010-09-13 3:03 ` Rusty Russell
2010-09-11 17:51 ` Dmitry Torokhov
2010-09-13 3:24 ` Rusty Russell
2010-09-17 10:55 ` pci: Re: #2 (Re: More modaliases + patchtool)) Dzianis Kahanovich
2010-09-17 13:11 ` Dzianis Kahanovich
2010-09-17 13:26 ` xenbus: " Dzianis Kahanovich
2010-09-17 18:09 ` Jeremy Fitzhardinge
2010-09-17 13:27 ` usb: " Dzianis Kahanovich
2010-09-17 13:29 ` serio: " Dzianis Kahanovich
2010-09-17 13:29 ` pnp: " Dzianis Kahanovich
2010-09-17 13:32 ` of: " Dzianis Kahanovich
2010-09-17 13:35 ` i2c: " Dzianis Kahanovich
2010-09-17 14:06 ` Mark Brown
2010-09-17 15:47 ` Dzianis Kahanovich [this message]
2010-09-17 15:54 ` Mark Brown
2010-09-17 13:36 ` hid: " Dzianis Kahanovich
2010-09-17 13:36 ` dio: " Dzianis Kahanovich
2010-09-17 13:37 ` ccw: " Dzianis Kahanovich
2010-09-17 13:38 ` acpi: " Dzianis Kahanovich
2010-09-17 13:38 ` spi " Dzianis Kahanovich
2010-09-17 13:39 ` RapidIO: " Dzianis Kahanovich
2010-09-17 13:42 ` platform: " Dzianis Kahanovich
2010-09-17 13:54 ` Mark Brown
2010-09-17 15:55 ` acpi (signed): " Dzianis Kahanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C938D9D.4070709@bspu.unibel.by \
--to=mahatma@bspu.unibel.by \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahatma@eu.by \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®