From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010036.outbound.protection.outlook.com [52.101.201.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B14AF19992C for ; Sat, 13 Jun 2026 18:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.36 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781376825; cv=fail; b=igS38cIWIR3VRnEPJ0MGmfCQZBzySfyPEYiMJdVs4Epxca0EgCTRZQCXx2wq/NkqtYmfBIrUc/RX7m7vT0uqAx2D9DKtfrnk24bjhgNvMEv44CGwmCqoQHX2HRqoPqiyvMHoR/jSR2nsI4rZNQa3EfCdADfp45rwYWNcQvJ66/E= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781376825; c=relaxed/simple; bh=kXHJW300P2gVq4i/ONZrwdH+5qJZyEPChSnT8sBg3TE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=MH+j4eDQ3W6phiWjuVNjTrTdOfvsLxUrakiLRIHhnQHoRNIqWfHWF1aPTvmthy+YtB+HI6073HqeUebIBgt9JRMLPHnz2zRgVzk79Q37VQPzl8rz3QZg6//TWw5/PL+dLVk/wN1HP7gr5ZW2RoXYGseO5cRDPpD7QqWiuz1WZ5Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=c6vgAHh+; arc=fail smtp.client-ip=52.101.201.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="c6vgAHh+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i27laTlbivNv/FeCNCS/2NTF2pSICYGEseZHJVQpzLyKeAY7IS8lyzwCck+0NwhJCYnjseG4SBzvD3le7BZlOiEWZKqO5tLRrqRVjIt69E8A/OpEcWxLGBKgJlW7eMd3K2tcQfo5YQdWFum2ZtAi71O+24TBnWHirdfy1bWyfLuJfhwqEM/8Zg3iaM/R6+uJRJBx1eAb2bW2yy/+Q4aAqory7K32of0MMCeBDY7G/OZH6UoQ3YBCVEWobIcT/G2bP/9i2atBlPHq1xL+oiNcLO2tW/dPW3rbqupMV18ZOodathzIkkvcV4RjWd/+qawgwebgqrHOO6/C31r+KKgvQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9eErUzSiEJ3y6xzB9bkwwD+8WiZFfn3TRpcZbRLKwTg=; b=hiUR8gIKnI4Y3jzfdsI0dZvgeGUkmRRSWjxwdA/rohu8bO5CIWUkK5i0kUoM5Ljw83yN+rNTTzxJ/2jLkSHLXGMhgcL+iNogFwr4O6LvU1xHCYDsQPIcqOEhGtQNlp6OACod4ZO/iSyBLjX2Mq8Zu5pDp2tPDo4URFqSsctolLqMeGlnJp3Re4PR5CkHRPTUc4ITR0Y91eBj3ocEqJ75YvWC5SEWTFDn33+2+eBH/Vsx0e7j7LUYyaTehgVveDwnFRud+r1EDWkl2JtMwmS1gLMQv9iV2PBM28cNeI6KjR4RLlZqBjWhaSe5cJRGI9qBseEXcSmaJEbfmjQpnp1HjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9eErUzSiEJ3y6xzB9bkwwD+8WiZFfn3TRpcZbRLKwTg=; b=c6vgAHh+fwliCoBYRRJ44V5soEz7zEPhdYzzaB6LAHy4vzQ93mJxj+Gkm2E8Cy2nuRDMj6FyP3x1VvVLweZQeXyRi8uIXap4Rim5KbXs6UKPfOdpdg5WrM47ja6BdsRCW8H4/0Po5+Zw9lxDyzGMBqpJCHGVB5m4Pis1grTDjmdZr/lov1u6/HYZLywyHu9JO8iEeRY0sj5K1+nuu66hD6DXTPehp4URPppb0UmgSQ/TwRvvLuHucBfgrZyju32F6YzQsPBre5U0sLNoXiAoVqZqeT6jBCxrEt+LWYNYzcidDlGz4X48CIoMu3nXR3GSjR6UaoxGf1mp5HJQ0voruQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by DM4PR12MB5748.namprd12.prod.outlook.com (2603:10b6:8:5f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.14; Sat, 13 Jun 2026 18:53:38 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%5]) with mapi id 15.21.0113.015; Sat, 13 Jun 2026 18:53:38 +0000 From: Zi Yan To: Usama Arif Cc: Andrew Morton , david@kernel.org, chrisl@kernel.org, kasong@tencent.com, ljs@kernel.org, ying.huang@linux.alibaba.com, Baoquan He , willy@infradead.org, youngjun.park@lge.com, hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, alex@ghiti.fr, kas@kernel.org, baohua@kernel.org, dev.jain@arm.com, baolin.wang@linux.alibaba.com, npache@redhat.com, "Liam R. Howlett" , ryan.roberts@arm.com, Vlastimil Babka , lance.yang@linux.dev, linux-kernel@vger.kernel.org, nphamcs@gmail.com, shikemeng@huaweicloud.com, kernel-team@meta.com Subject: Re: [v2 02/16] mm: extract mm_prepare_for_swap_entries() helper Date: Sat, 13 Jun 2026 14:53:36 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: <4C93E320-2F5C-46B2-AC5E-A416D4D38B96@nvidia.com> In-Reply-To: <20260602142537.198755-3-usama.arif@linux.dev> References: <20260602142537.198755-1-usama.arif@linux.dev> <20260602142537.198755-3-usama.arif@linux.dev> Content-Type: text/plain X-ClientProxiedBy: YQBPR0101CA0347.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6b::8) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|DM4PR12MB5748:EE_ X-MS-Office365-Filtering-Correlation-Id: f4d4be34-f16b-45e2-6fe5-08dec97d14a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|7416014|376014|366016|10070799003|4143699003|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: +eSEfbC6D4RRW4L6YPaBQD5HHqwGDgiITWesRLdeuzyAdWeAtOjfaHd2A3jMmD9r7jfMZK7+rWIKIOMn3bl1X9ozoJV1vBrLF5kCftDAZoetpdfHVfqug44WOhS11qSFDPsvzoRAod8edWS0TeVzIZ8CgY/JJakB6rtNgCrZ2XC21cEyWndQg9SrThoMvHv4ORS0j9y6tl6OdZFL7j2qcZ0NvFuFyWLyhyqy0fZK0sZdgpKQrTTniQiIgZit+atYAK9sGBmkNRjCslNaT+0T/xH07/u13HOXlHDAIR0laDUMVPE/drPRn592kZjS9bj+G9naUONInY4vROc4ts8uVx1ql5XrGu6B9IUK0BqA4AzbowvKt4bTRgh9k4vh+El1YwzbSPH+NEeqPjHV4FhxBtF99RCX59laPjuUGjxyaCopMaObm2ikWWmPBdLYoOLBrbXJHCIYXwii+m5LS1Zfo8byoEtxuVwoxIuXYHgKzWZi1VIKgovV62TqMXOS9LLOdtfCmICDA+yDMFw4XaLz+Qm+AxBd5FhEwnjsFYXQbj2RXqC7SoV462etDRUew7mMyv0BLK3juj7wgTxy4TDo4fyW0+7V/8FO2od0QRHDqn9elKgUybvFry7/NuG+bSx2/85v/xgPufhSJ3e6V+QNMuuKMj12DjgmxyyXv1FCjsO2X0l8k6RcgITPkozT+suH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(7416014)(376014)(366016)(10070799003)(4143699003)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GKCqJcxt+WcMPfeMBXgZYfyCBCulA83XcH2C5Wz1egT3H+8j+ykPB6TmD7Ad?= =?us-ascii?Q?lBW8FgnfxqJfcm23bbL7T+EedMtY0I3iDh4+LHifls7QnDN1l72C0QnzeEq/?= =?us-ascii?Q?xi+PE+mnXTu2ng4qYkFagNibshpzZ7Dbiqher6VnVhZ/YAmN5ZE9Q1Q9yZKc?= =?us-ascii?Q?6cG7nUppZUwKoBPJMtlx4IR4erx7CkY7vzHxwi+RYJg/mBoQqnqJta6lSFfz?= =?us-ascii?Q?33UTqHP8TZdpGvttuZyfhzigkuq2o9NI4cXXAoU/i8+7YIXFRjkyd59MPnea?= =?us-ascii?Q?wutJj7m488DNaarL7odRLQmxV+wbcBN588WdJ50VffeevQtiXStY8Ro1bwdy?= =?us-ascii?Q?QlrINgsrFJiSu+UEmjXIzSW1Sq5hbI9AyDj1bAgf1qA1IKfAs4c/libjKo9+?= =?us-ascii?Q?sF6EOgFRmUeohCt70tabsB+bOOEtcn3BaQlx+sJDgvjg4EFsRxIV2NNzFXkk?= =?us-ascii?Q?/RDrChlsCs1XY1wVbnJmXj70diIdG4SumyRvnZYwH2yMZZ64ptCeu96FdrsL?= =?us-ascii?Q?If/1UvA8a7bpQSUH0EMYXt+zPDHlvUokUMHL/l7+hVUKMRTkpdo5IV/9/pEj?= =?us-ascii?Q?R9tuUP8IYYtFcFx5P2i/+rh9A5AxLuFURoBpUAySpNoHja2Kpx8h/Kqkqhah?= =?us-ascii?Q?Mr6rlSQdJ9LO3NzZv0Xm5Nb7tG1dVymmn1sr44CawpKbCb4JFhYZOUOKwkHt?= =?us-ascii?Q?CwkxuLDFhDG7iQEDAUF6YxSTJpn7DNDD/UV0CNJ2pAeA+uGJK0ByGJczxrdm?= =?us-ascii?Q?GeCoQx/2b70U7E1N0sINnKlhyB/MpkrBOlATiOVLM7NyyOwSQkjec6OqAscr?= =?us-ascii?Q?JzjpD9gjEyP1DtDFoirr17Vqy360N9pQUM1zgtJoS41C1cUlEPJOoh92xxny?= =?us-ascii?Q?kYNjvO7ie3ovkSRZJT9ZnamdJ2YOOhcA6fK5zSoQAwj7QXfKnd/KXNgAh1QX?= =?us-ascii?Q?r9pCQOAJNFApDOlYw9n4xaUI3fWjYPmcTjXDWN1+jLbMSeqAV+uLAuzHEVkX?= =?us-ascii?Q?m0et4p+7spWLLgDKCJgFN0yXL7FBTsDKFnH9LyDl/WqjS1BgBbPs5h39ro1X?= =?us-ascii?Q?KnZNV5Xix8qe04wdhWDN22zwhTXeptVX9MC0bk+wiOOqMGKROkc7Hcrg16nq?= =?us-ascii?Q?3WUszjUTm8mWya7o9xJFhXHeQiNHW18/ZFa8SMK3I1A1GADKwmwzPW8iSrFA?= =?us-ascii?Q?RrX9QtSz1PDGTnsRCVrhA6H/Lg+h5IK2F5pch+U7QKfb38WmmSXOigtqQ4xf?= =?us-ascii?Q?V65tlfLQjW3VbXESJkohB9z56noPJAoGFk0jAxB62zDuQlIrQIGXCja2La9B?= =?us-ascii?Q?qSpwUVCkiD2X9sgCatWmKXQYvnzoOn1hS32kx3atBCZ2ulV6Vge4wTNL0k2v?= =?us-ascii?Q?xuPmm0SHovVSXBV9txNhvW+YLLj34TN2+NtnZZrNNY2Nr+3JYtACdj/WPVoO?= =?us-ascii?Q?F+sSzO0OD/kwPzQ2lH+Q8ey/U4FqInQ76TWZxGSJYvuWnuCqh9MrTmu9/UPZ?= =?us-ascii?Q?BRYAAeSzaPaKbWp9fS/5x0BI7AY4eASfTGTpEKwhU0IKtqhllqf5YvxuDMRP?= =?us-ascii?Q?xw0nV2hwSvbduz+SPlslI/u/hOBWx3SBQYTcNcWMx4A8vsdsvWY5H46zXEHz?= =?us-ascii?Q?Ke90GXkWG3bhXTfDzJFOj5tj9TWhOtlM3nOtNvDngRWGaPg8OmBU2QDo+4yw?= =?us-ascii?Q?AKsVliWhdKN35uTBN4RZx8aTM2Uu5c2RxrZydo/1iniYhcr8H2L5mZEP0A7B?= =?us-ascii?Q?vTCGN8qn1jh351fZ/4nrYDLEqdy94u++7EUFYda6Us3K4shL/xAv?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4d4be34-f16b-45e2-6fe5-08dec97d14a2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2026 18:53:38.8272 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IGvVcPsFrKMv3ouCiNuG3xuxtEPLdDaqliYCBgV9AlTR6QVdTXo6SWdviU8pZ0rf X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5748 On 2 Jun 2026, at 10:24, Usama Arif wrote: > When a swap entry is installed in a page table, the mm must be added > to init_mm.mmlist so that swapoff can find and unuse its swap entries. > This double-checked locking pattern is currently open-coded in > try_to_unmap_one() and copy_nonpresent_pte(). > > Move it into mm_prepare_for_swap_entries() in mm/internal.h and convert > both callers so it can be reused by upcoming PMD-level swap entry code > paths that also need to register the mm with swapoff. > > copy_nonpresent_pte() previously inserted into &src_mm->mmlist rather > than &init_mm.mmlist, but the insertion point is irrelevant, mmlist > is a circular list and swapoff walks it entirely from init_mm.mmlist, > so only membership matters, not position. > > Reviewed-by: Dev Jain > Signed-off-by: Usama Arif > --- > mm/internal.h | 13 +++++++++++++ > mm/memory.c | 9 +-------- > mm/rmap.c | 7 +------ > 3 files changed, 15 insertions(+), 14 deletions(-) > LGTM. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi