From: Michael Tokarev <mjt@tls.msk.ru>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
Pedro Francisco <pedrogfrancisco@gmail.com>,
linux-kernel@vger.kernel.org,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream-fixes] ahci: fix module refcount breakage introduced by libahci split
Date: Tue, 21 Sep 2010 11:32:24 +0400 [thread overview]
Message-ID: <4C985F88.1010501@msgid.tls.msk.ru> (raw)
In-Reply-To: <4C985DFC.7020203@gmail.com>
21.09.2010 11:25, Tejun Heo wrote:
> libata depends on scsi_host_template for module reference counting and
> sht's should be owned by each low level driver. During libahci split,
> the sht was left with libahci.ko leaving the actual low level drivers
> not reference counted. This made ahci and ahci_platform always
> unloadable even while they're being actively used.
>
> Fix it by defining AHCI_SHT() macro in ahci.h and defining a sht for
> each low level ahci driver.
>
> stable: only applicable to 2.6.35.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Cc: stable@kernel.org
> ---
> Michael, thanks a lot for spotting it and bearing with me.
Um. All thanks goes to Pedro Francisco please, not to me -
I just verified your patch on my system, it was Pedro who spotted
and reported this. You may add my
Tested-Off-By: Michael Tokarev <mjt@tls.msk.ru>
, but not Reported-by... please ;)
Thanks!
/mjt
next prev parent reply other threads:[~2010-09-21 7:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 21:56 ahci rmmodable and shouldn't Pedro Francisco
2010-09-16 21:58 ` Randy Dunlap
2010-09-17 9:53 ` Tejun Heo
2010-09-19 10:28 ` Pedro Francisco
2010-09-19 12:32 ` Tejun Heo
2010-09-20 9:25 ` Pedro Francisco
2010-09-20 9:31 ` Tejun Heo
2010-09-20 9:41 ` Tejun Heo
2010-09-20 20:44 ` Pedro Francisco
2010-09-20 22:09 ` Tejun Heo
2010-09-20 22:10 ` Tejun Heo
2010-09-21 6:14 ` Michael Tokarev
2010-09-21 7:25 ` [PATCH #upstream-fixes] ahci: fix module refcount breakage introduced by libahci split Tejun Heo
2010-09-21 7:32 ` Michael Tokarev [this message]
2010-09-21 8:17 ` Tejun Heo
2010-09-23 15:14 ` ahci rmmodable and shouldn't Pedro Francisco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C985F88.1010501@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pedrogfrancisco@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome