From: "Jan Beulich" <JBeulich@novell.com>
To: <chris@chris-wilson.co.uk>
Cc: <eric@anholt.net>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] some clean up to intel-gtt.c
Date: Fri, 24 Sep 2010 13:25:30 +0100 [thread overview]
Message-ID: <4C9CB4DA0200007800018CFE@vpn.id2.novell.com> (raw)
In commit e517a5e97080bbe52857bd0d7df9b66602d53c4d the call to
map_page_into_agp() got removed from intel_i830_setup_flush(), but the
counterpart call from intel_i830_fini_flush() to unmap_page_from_agp()
was left in place.
Additionally, the page allocated here never gets its physical address
used for sending to hardware, so there's no need to allocate it with
GFP_DMA32. Nor is __GFP_ZERO really necessary, as the page is used
only to store data to force flushing of some internal processor state.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Eric Anholt <eric@anholt.net>
---
drivers/char/agp/intel-gtt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.36-rc5/drivers/char/agp/intel-gtt.c
+++ 2.6.36-rc5-intel-agp-cleanup/drivers/char/agp/intel-gtt.c
@@ -768,7 +768,6 @@ static void intel_i830_fini_flush(void)
{
kunmap(intel_private.i8xx_page);
intel_private.i8xx_flush_page = NULL;
- unmap_page_from_agp(intel_private.i8xx_page);
__free_page(intel_private.i8xx_page);
intel_private.i8xx_page = NULL;
@@ -780,7 +779,7 @@ static void intel_i830_setup_flush(void)
if (intel_private.i8xx_page)
return;
- intel_private.i8xx_page = alloc_page(GFP_KERNEL | __GFP_ZERO | GFP_DMA32);
+ intel_private.i8xx_page = alloc_page(GFP_KERNEL);
if (!intel_private.i8xx_page)
return;
next reply other threads:[~2010-09-24 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 12:25 Jan Beulich [this message]
2010-09-24 12:38 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9CB4DA0200007800018CFE@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=chris@chris-wilson.co.uk \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®