From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FF802FFDEE for ; Sat, 28 Feb 2026 20:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772312077; cv=none; b=o9yKw5DXRYqr98AvF4E8cF3WwaqssxWvqqgeMp1fCiSY1JofCDNgXLhUZ+qKxnGICgfj5ifn8771OB+T+PnLDKyOZ0WrPqscAL+1qS0uweCQUvIeaG05XUpgPKFz+7Fr8iW6OnO3lU2i84zQ0P/UNEyNqyf8MbSrl+Ge2gJ6AFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772312077; c=relaxed/simple; bh=A54o0fRlYXYiX6f5a1IPgxuDtjkOjMBT1FuckY80TuY=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=pGnveBB6Vxrc++LXWfsh6cHfLoM38cXkQ/SE7z8H3daoS4UGJMHJSox+tJyuroYp0t66gKAq9i6sT7qt85RdU9uFS/8DihOBZO83V08jXEJFUW0UKuFhGshGu4bNiY0SN5f07m5caV3xacSEi12wMWbqXuF0q3xeaSvOXSjJ2mU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sr26O0Y4; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sr26O0Y4" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b939cfc1e83so37647166b.0 for ; Sat, 28 Feb 2026 12:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772312074; x=1772916874; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GN2+88bWo1z1i+3BXW1R0w5iwrpOTleYOh4/PvtS7kQ=; b=Sr26O0Y4QHHJWtRdnKGN3IllO4lqd/f5FRQbOzqsbJWkaWvMM4SdvdOY8Js+diW1SE eBkfIH9yttgwJOevM4Z+XEvy7K6hZEgejeln/Q7UXl6kIT5M3vl5C2a6QIaXfLPyRQkY mtiU8DlVNJVKhwM8LPLXUd8TAv1ufKvwroVAVMbu9xt+99EICif136HbgxOrcuCWQmyH Kvy505G+fohxORqNdM7LWxpGJ1S50D6SezGDiXFUgdA/hU9V309EsgUctmv6rW416Hea /iTM4ubnCGFV6FlKZJNBeaGfh49VmknD1Q0dqu0vOAGgt1Jd0A0WjpqCwt0zopU81OOM lo3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772312074; x=1772916874; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GN2+88bWo1z1i+3BXW1R0w5iwrpOTleYOh4/PvtS7kQ=; b=Ojn8WzjmSejrDJW2W2CnQ71gldPDeVN93e4qDgEhX1EFZnqEESbQS7oUV3fUpYhHSE 8Y0r74fgRPXeqxiNckgrLnOYzbnth8Tx4gEMYe/eEDGYpGfgbTA+ZfL3sCuiNfVjefnR /p3VkpBdrlWLR00FRWZzPd06csVCFwOY85s0DH4+D7hgRT8d5STSHyuiy6SmJrqbX8hM 4PuBm4n8oIVT1CWa1VpeI9UMR1VGCgjvFREtPZuuhWe4CSwBYdUortr7SrNV5kw5LP7P gzWvAZgc7NpQb2oPUDamRaRi+wRrfhtrMfzAwKqsXImkn8Tx3xKn93Pepkk7INGM/jMl xd3g== X-Forwarded-Encrypted: i=1; AJvYcCWvkqsWSIxY4V+WJ7nzWZplkweIB5iWoCvbS4BW7O/8k3CSOEBFj7KOdZB7UZvLe/NGHARp5uSPDGFiSXg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2qENtkCXq0ts8CUNvdsUNJYFM29lTk86UaXMsenm6iZs3BbzM 4pQi3LCBGpvjQD0JzFrhQhQRO5WBCQz1i3+UWLG5pgyeXyYNTahZxZKi X-Gm-Gg: ATEYQzw1BE/46/YXcpR96nbPLu2x9vtCxR5USv+TyREawU+F2JojNQulDkFgSn3VvMl ckUR7as9zf3a9Koz7awyMCGzdmHPfVyHPAeW7V7pwNb72uYQ6pFZarkjbUzonoG4PFV9atMG94A 8+INGLd2FiOVS1Yh3uM2+JACnOEtKzBSLHmx3raY7myXqqP3OWoPcrOOxB/1ZU0NVGQ2bXT/M7t FyBhjSwpAiNphkvpogkQCnmX/pLMw83m1o303uSYUDl25lMoDYcY26fxD+NbeRAi+KhlxAOO4ae gyCM/gVJpQOoSj9iOEq3x45T7H4FoNft1inbBgojCLwqCMSlVmPeuWlYKCJ+WuRZvKMZopnfbS2 zgeeyl00BH69yQwJQXzPhPrT+zWkh/Nb+XQpwXJXUR0Geewff7vM+BGIOqdLjSRiMmJyIfhsxCg g289t1MsMRj8JCs1fnbE/YkSl8biYXej7YBwbmKTXjwdOwAZzufgUs0EfnRfQ2U9WDxta6yns3o ZkHoYoPl//PwUH3CWx6+goplraMooJRvxkYLbzJsXYq6/mccPMNjCkWj5ZjTSWcgA== X-Received: by 2002:a17:907:2d2c:b0:b88:713e:7895 with SMTP id a640c23a62f3a-b937636ce1fmr468067366b.3.1772312073608; Sat, 28 Feb 2026 12:54:33 -0800 (PST) Received: from smtpclient.apple (89-66-237-154.dynamic.play.pl. [89.66.237.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ac70b01sm272676466b.23.2026.02.28.12.54.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Feb 2026 12:54:32 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: [PATCH] media: venus: allow interlaced video streams From: Piotr Oniszczuk In-Reply-To: <20260228-venus-mpeg2-v1-1-c13aa7cb6e93@oss.qualcomm.com> Date: Sat, 28 Feb 2026 21:54:20 +0100 Cc: Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Stanimir Varbanov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <4CA1838F-504D-4EEA-99F4-B3CC5EB10EDA@gmail.com> References: <20260228-venus-mpeg2-v1-1-c13aa7cb6e93@oss.qualcomm.com> To: Dmitry Baryshkov X-Mailer: Apple Mail (2.3826.700.81.1.4) > Wiadomo=C5=9B=C4=87 napisana przez Dmitry Baryshkov = w dniu 28 lut 2026, o godz. 10:49: >=20 > Venus driver errors out on the interlaced streams with the 'field = isn't > supported' error message, which e.g. prevents decoding of the MPEG2 > video streams. Don't error out if the buffer is set to contain > interlaced data. >=20 > Tested with the fluster enabled to handle MPEG2 through Gstreamer: >=20 > ./fluster.py r -d GStreamer-MPEG2_VIDEO-V4L2-Gst1.0 -s -so = venus-mpeg2.md -j 1 >=20 > GLOBAL SUMMARY > |TOTALS|GStreamer-MPEG2_VIDEO-V4L2-Gst1.0| > |-|-| > |TOTAL|30/52| > |TOTAL TIME|75.526s| > |-|-| > |Profile|GStreamer-MPEG2_VIDEO-V4L2-Gst1.0| > |MAIN|26/32| > |PROFILE_4_2_2|0/9| > |SIMPLE|4/11| > |-|-| >=20 > Fixes: 059790467bf4 ("media: venus: helpers: handle correctly vbuf = field") > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/venus/helpers.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/drivers/media/platform/qcom/venus/helpers.c = b/drivers/media/platform/qcom/venus/helpers.c > index 747c388fe25f..71e79093a4c7 100644 > --- a/drivers/media/platform/qcom/venus/helpers.c > +++ b/drivers/media/platform/qcom/venus/helpers.c > @@ -1466,11 +1466,6 @@ int venus_helper_vb2_buf_prepare(struct = vb2_buffer *vb) > if (V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type)) { > if (vbuf->field =3D=3D V4L2_FIELD_ANY) > vbuf->field =3D V4L2_FIELD_NONE; > - if (vbuf->field !=3D V4L2_FIELD_NONE) { > - dev_err(inst->core->dev, "%s field isn't supported\n", > - __func__); > - return -EINVAL; > - } > } >=20 > if (vb->type =3D=3D V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE && >=20 > --- > base-commit: 779cae956c8316aebc1946ef86ca001f99658270 > change-id: 20260228-venus-mpeg2-495f9187a1ec >=20 > Best regards, > --=20 > With best wishes > Dmitry >=20 >=20 Dmitry, I applied this on 6.19.4 mainline and give run with interlaced content = (hd tv) on qcs6490 (radxa dragon sbc). Playback fails like this: = https://gist.github.com/warpme/a368983678af0a76af85314808773076 pls see a bootom kernel output showing venus failure. my sw stack plays ok on e.g rpi4 stateful v4l2m2m so i think root cause = isn't in my userspace.... pls let me know if anything extra is required to fix venus decoder = issue. br=20 =20=