From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932835Ab0JEKgY (ORCPT ); Tue, 5 Oct 2010 06:36:24 -0400 Received: from adelie.canonical.com ([91.189.90.139]:40005 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753938Ab0JEKgX (ORCPT ); Tue, 5 Oct 2010 06:36:23 -0400 Message-ID: <4CAAFF99.6060504@canonical.com> Date: Tue, 05 Oct 2010 18:36:09 +0800 From: Ike Panhc User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8 MIME-Version: 1.0 To: Stephen Rothwell CC: Matthew Garrett , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown Subject: Re: linux-next: build failure after merge of the drivers-x86 tree References: <20101005151126.eadae817.sfr@canb.auug.org.au> In-Reply-To: <20101005151126.eadae817.sfr@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2010 12:11 PM, Stephen Rothwell wrote: > Hi Matthew, > > After merging the drivers-x86 tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > make[4]: *** No rule to make target `drivers/platform/x86/ideapad_laptop.c', needed by `drivers/platform/x86/ideapad_laptop.o'. Stop. > > Caused by commit 9efe5c1540a1e03cb2e0fca85e49fc4c57c6e771 ("ideapad: > Change the driver name to ideapad-laptop"). The commit renames > ideapad_acpi.c to ideapad-laptop.c but the Makefile uses ideapad_laptop.o > (note underscore v. dash). > > Presumably this was never even build tested :-( > > I have used the drivers-x86 tree from next-20101004 for today. Sorry, my fault. This line is wrong, +obj-$(CONFIG_IDEAPAD_LAPTOP) += ideapad_laptop.o shall be +obj-$(CONFIG_IDEAPAD_LAPTOP) += ideapad-laptop.o How shall I fix it? resend the whole patches or just this one?