mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	rpurdie@rpsys.net
Subject: Re: mmotm 2010-10-13-17-13 uploaded (leds)
Date: Thu, 14 Oct 2010 13:32:55 -0700	[thread overview]
Message-ID: <4CB768F7.90009@oracle.com> (raw)
In-Reply-To: <1287087217.4641.442.camel@jlt3.sipsolutions.net>

On 10/14/10 13:13, Johannes Berg wrote:
> On Thu, 2010-10-14 at 09:14 -0700, Randy Dunlap wrote:
> 
>>> Are there dependencies missing? I was under the impression that this
>>> shouldn't be happening. And what's the point in having triggers, but
>>> nothing to trigger...? How about the patch below?
>>
>> It seems to be due to net/mac80211/Kconfig:
>>
>> config MAC80211_LEDS
>> 	bool "Enable LED triggers"
>> 	depends on MAC80211
>> 	select NEW_LEDS
>> 	select LEDS_TRIGGERS
> 
> Ohh. Indeed, that should be easy to fix, make it depend on
> LEDS_TRIGGERS=y || LEDS_TRIGGERS=MAC80211 or so?

Yes.

>>> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>
>> The patch does not apply cleanly to mmotm, but it seems
>> like a good plan...
> 
> Hmm, ok, it was against the latest -rc or so. It'll have to wait a bit,
> I'm about to leave for a week. Sorry!

No problem.

later,
-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2010-10-14 20:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-14  0:13 mmotm 2010-10-13-17-13 uploaded akpm
2010-10-14  4:17 ` mmotm 2010-10-13-17-13 uploaded (staging/bcm) Randy Dunlap
2010-10-14 19:14   ` Greg KH
2010-10-14 20:38     ` Randy Dunlap
2010-10-14  4:29 ` mmotm 2010-10-13-17-13 uploaded (leds) Randy Dunlap
2010-10-14 11:38   ` Johannes Berg
2010-10-14 16:14     ` Randy Dunlap
2010-10-14 20:13       ` Johannes Berg
2010-10-14 20:32         ` Randy Dunlap [this message]
2010-10-26 10:14           ` Johannes Berg
2010-10-14 10:26 ` mmotm 2010-10-13-17-13 uploaded Zimny Lech
2010-10-14 19:16   ` Andrew Morton
2010-10-14 19:23     ` Zimny Lech
2010-10-14 20:06 ` mmotm 2010-10-13 - GSPCA SPCA561 webcam driver broken Valdis.Kletnieks
2010-10-15  8:45   ` Hans Verkuil
2010-10-15  9:05     ` Andrew Morton
2010-10-15 10:02       ` Hans Verkuil
2010-10-15 12:05         ` Mauro Carvalho Chehab
2010-10-15 12:23           ` Hans Verkuil
2010-10-18 19:00             ` Mauro Carvalho Chehab
2010-10-18 19:39               ` Hans Verkuil
2010-10-20 15:50 ` ptrace BUG [was: mmotm 2010-10-13-17-13 uploaded] Jiri Slaby
2010-10-20 15:52   ` Peter Zijlstra
2010-10-20 15:54   ` Frederic Weisbecker
2010-10-20 16:03     ` Jiri Slaby
2010-10-20 16:13       ` Peter Zijlstra
2010-10-20 17:29         ` Jiri Slaby
2010-10-21  7:34         ` Jiri Slaby
2010-10-21  7:40           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CB768F7.90009@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome