mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: David Brownell <david-b@pacbell.net>,
	USB list <linux-usb@vger.kernel.org>,
	Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.36-rc7: NULL pointer dereference in ehci_clear_tt_buffer_complete
Date: Sat, 16 Oct 2010 22:35:24 +0200	[thread overview]
Message-ID: <4CBA0C8C.6050909@s5r6.in-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1010161600240.21391-100000@netrider.rowland.org>

Alan Stern wrote:
> On Sat, 16 Oct 2010, Stefan Richter wrote:
>> Alan Stern wrote:
>>> --- usb-2.6.orig/drivers/usb/core/message.c
>>> +++ usb-2.6/drivers/usb/core/message.c
>>> @@ -323,8 +323,13 @@ static void sg_complete(struct urb *urb)
>>>  	/* on the last completion, signal usb_sg_wait() */
>>>  	io->bytes += urb->actual_length;
>>>  	io->count--;
>>> -	if (!io->count)
>>> +	if (!io->count) {
>>> +		if (status == -ECONNRESET) {
>>> +			printk(KERN_ERR "Delaying for test\n");
>>> +			mdelay(600);
>>> +		}
>>>  		complete(&io->complete);
>>> +	}
>>>  
>>>  	spin_unlock(&io->lock);
>>>  }
>>>
>> I did so today on 2.6.36-rc8, without your other patch.  I was still unable to
>> reproduce the bug.  Forget the whole thing as unreproducible?
> 
> What I said above wasn't quite right.  This won't help trigger the 
> oops, but it should trigger the line saying something like
> 
> 	ehci_hcd 0000:00:12.2: qh ffff880208f07af0 (#00) state 5
> 
> That's the real bug.

# grep ' qh ' /var/log/messages
Oct 11 22:29:21 stein kernel: ehci_hcd 0000:00:12.2: qh ffff880208f07af0 (#00)
state 5

I.e. there was none anymore since the one which I reported on Monday.
-- 
Stefan Richter
-=====-==-=- =-=- =----
http://arcgraph.de/sr/

  reply	other threads:[~2010-10-16 20:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 20:56 Stefan Richter
2010-10-12 18:23 ` Alan Stern
2010-10-13 14:23 ` Alan Stern
2010-10-13 22:42   ` Stefan Richter
2010-10-14 14:25     ` Alan Stern
2010-10-16 19:44       ` Stefan Richter
2010-10-16 20:05         ` Alan Stern
2010-10-16 20:35           ` Stefan Richter [this message]
2010-10-17 13:50             ` Alan Stern
2010-10-19 14:54               ` Alan Stern
2010-10-24 11:49                 ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBA0C8C.6050909@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®