From: Jens Axboe <jaxboe@fusionio.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dan Carpenter <error27@gmail.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
"cbe-oss-dev@lists.ozlabs.org" <cbe-oss-dev@lists.ozlabs.org>
Subject: Re: [PATCH] block: Turn bvec_k{un,}map_irq() into static inline functions
Date: Sun, 17 Oct 2010 20:06:53 +0200 [thread overview]
Message-ID: <4CBB3B3D.5050800@fusionio.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1010171335400.919@ayla.of.borg>
On 2010-10-17 13:38, Geert Uytterhoeven wrote:
> Convert bvec_k{un,}map_irq() from macros to static inline functions if
> !CONFIG_HIGHMEM, so we can easier detect mistakes like the one fixed in
> 93055c31045a2d5599ec613a0c6cdcefc481a460 ("ps3disk: passing wrong variable to
> bvec_kunmap_irq()")
Does this cause any warnings on the existing kernel? It's the same issue
we have with the kunmap_atomic() API, and they are generally used to map
structures etc as well. So char * isn't necessarily always a good
choice, and hence the "fix" there is to just check whether a page struct
is being passed in or not.
OK, so did a quick grep, and there's just the two users of it. So pretty
straight forward, I'll add your patch. Thanks!
--
Jens Axboe
prev parent reply other threads:[~2010-10-17 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 11:38 Geert Uytterhoeven
2010-10-17 18:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBB3B3D.5050800@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=error27@gmail.com \
--cc=geert@linux-m68k.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome