From: "Jan Beulich" <JBeulich@novell.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <heukelum@fastmail.fm>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] i386: restore parentheses around one pushl_cfi argument
Date: Fri, 22 Oct 2010 08:22:35 +0100 [thread overview]
Message-ID: <4CC157DB020000780001E8A2@vpn.id2.novell.com> (raw)
These were (intentionally) stripped by "fix CFI macro invocations to
deal with shortcomings in gas" to expose problems with unexpected
splitting of arguments by older gas also on newer versions, but as it
turns out there is at least one distro (Ubuntu 6.06) where even not
having *any* spaces in a macro argument doesn't reliably prevent
splitting into multiple arguments.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
---
arch/x86/kernel/entry_32.S | 2 +-
1 files changed, 1 insertion, 1 deletion
--- 2.6.36-x86-cfi.orig/arch/x86/kernel/entry_32.S
+++ 2.6.36-x86-cfi/arch/x86/kernel/entry_32.S
@@ -395,7 +395,7 @@ sysenter_past_esp:
* A tiny bit of offset fixup is necessary - 4*4 means the 4 words
* pushed above; +8 corresponds to copy_thread's esp0 setting.
*/
- pushl_cfi TI_sysenter_return-THREAD_SIZE_asm+8+4*4(%esp)
+ pushl_cfi (TI_sysenter_return-THREAD_SIZE_asm+8+4*4)(%esp)
CFI_REL_OFFSET eip, 0
pushl_cfi %eax
next reply other threads:[~2010-10-22 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 7:22 Jan Beulich [this message]
2010-10-22 9:56 ` [tip:x86/debug] x86, asm: Restore " tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC157DB020000780001E8A2@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®