From: Jens Axboe <axboe@kernel.dk>
To: Milan Broz <mbroz@redhat.com>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: OOPs on loop module removal
Date: Sun, 24 Oct 2010 22:07:38 +0200 [thread overview]
Message-ID: <4CC4920A.5050100@kernel.dk> (raw)
In-Reply-To: <4CC48587.5010907@redhat.com>
On 2010-10-24 21:14, Milan Broz wrote:
>
>
> Hi,
> Simple modprobe loop ; rmmod loop
> on Linus' tree now produces now OOPS.
>
> Bisected to patch (and reverting fixes problem)
>
> commit 7681bfeeccff5efa9eb29bf09249a3c400b15327
> Author: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> Date: Tue Oct 19 09:05:00 2010 +0200
>
> block: fix accounting bug on cross partition merges
>
> The problem is probably that patch uses directly q->queue_lock
> even if queue is being destroyed (QUEUE_FLAG_DEAD is set).
> See what loop (and not only this code) does:
>
> blk_cleanup_queue(lo->lo_queue);
> put_disk(lo->lo_disk);
Yep that commit was not the most fortunate one. I will send out a revert
now, which will gives us time to fix this for real without rushing
things.
--
Jens Axboe
prev parent reply other threads:[~2010-10-24 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 19:14 Milan Broz
2010-10-24 20:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC4920A.5050100@kernel.dk \
--to=axboe@kernel.dk \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome