From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756198Ab0JYP3r (ORCPT ); Mon, 25 Oct 2010 11:29:47 -0400 Received: from vpn.id2.novell.com ([195.33.99.129]:50606 "EHLO vpn.id2.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487Ab0JYP3p convert rfc822-to-8bit (ORCPT ); Mon, 25 Oct 2010 11:29:45 -0400 Message-Id: <4CC5BE83020000780001EFE4@vpn.id2.novell.com> X-Mailer: Novell GroupWise Internet Agent 8.0.1 Date: Mon, 25 Oct 2010 16:29:39 +0100 From: "Jan Beulich" To: "Linus Torvalds" Cc: "Ingo Molnar" , "Alexander van Heukelum" , , "H. Peter Anvin" , "David Howells" , , Subject: Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets References: <4CC5B1A1020000780001EF7C@vpn.id2.novell.com> <20101025140218.5092.74117.stgit@warthog.procyon.org.uk> <28707.1288018465@redhat.com> <4CC5B8D3020000780001EFB4@vpn.id2.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 25.10.10 at 17:17, Linus Torvalds wrote: > How about just removing the idiotic workaround entirely, and then on > x86 passing "-traditional" to cpp for asm input so that it doesn't add > spaces in argument expansion? Make the workaround more targeted to the > actual problem, rather than working around it in some unrelated > thing.. Hmm, I think it was an actual improvement to remove the use of -traditional. If fiddling with the globally used sed expression isn't considered acceptable, how about allowing the architecture to override it as necessary? Jan