mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: "Yinghai Lu" <yinghai@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <jbarnes@virtuousgeek.org>
Subject: your patch "x86/PCI: host mmconfig detect clean up"
Date: Wed, 03 Nov 2010 11:27:36 +0000	[thread overview]
Message-ID: <4CD15538020000780002060B@vpn.id2.novell.com> (raw)

In this patch (commit 068258bc15439c11a966e873f931cc8e513dca61)
you made the call to pci_mmcfg_reject_broken() unconditional. This
breaks pci=check_enable_amd_mmconf when the mmconfig space
wasn't enabled by the BIOS, since obviously the BIOS can't reserve
in the E820 map the range Linux is going to assign. As the commit
message doesn't really tell the reason for you doing so, could you
shed some light on this, so a proper change to restore the original
functionality can be put together?

Thanks, Jan


             reply	other threads:[~2010-11-03 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-03 11:27 Jan Beulich [this message]
2010-11-04 20:22 ` Yinghai Lu
2010-11-05 10:08   ` Jan Beulich
2010-11-05 18:06     ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD15538020000780002060B@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®