From: Larry Finger <Larry.Finger@lwfinger.net>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: pali.rohar@gmail.com, Greg Kroah-Hartman <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/RFT] OHCI: Fix for regression in 2.6.37-rc1 since commit 3df7169e7
Date: Wed, 03 Nov 2010 20:10:56 -0500 [thread overview]
Message-ID: <4CD20820.1070406@lwfinger.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1011031647140.15616-100000@netrider.rowland.org>
On 11/03/2010 04:04 PM, Alan Stern wrote:
>
> This patch is definitely wrong -- it defeats the entire purpose of
> rewriting the control register! That write was added _specifically_ to
> put the controller into reset, i.e., to change the functional state.
>
> Furthermore, the write does the same thing as ohci_hcd.c does in its
> ohci_usb_reset() routine. Regardless, ohci_run() does a complete host
> controller reset, which should override anything done in pci-quirks.c.
> Perhaps _that_ routine needs some attention.
It is looking as if your patch is exposing a different bug. When I disable the
write in pci_quirks leaving the controllers in OPER or RESUME mode, then
ohci_run() is not called. I'm still trying to find out why.
Larry
next prev parent reply other threads:[~2010-11-04 1:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 18:20 Larry Finger
2010-11-03 21:04 ` Alan Stern
2010-11-04 1:10 ` Larry Finger [this message]
2010-11-04 14:41 ` Alan Stern
2010-12-11 0:17 ` Larry Finger
[not found] <AANLkTikgzdggq4HdBiS7M_6qs1vKbZRkbR70Y=m2JxVu@mail.gmail.com>
2010-11-12 22:02 ` Alan Stern
[not found] <4D03AACB.8020205@lwfinger.net>
2010-12-11 19:47 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD20820.1070406@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome