From: "Jan Beulich" <JBeulich@novell.com>
To: "Andreas Herrmann" <herrmann.der.user@googlemail.com>
Cc: <mingo@elte.hu>, "Yinghai Lu" <yinghai@kernel.org>,
<tglx@linutronix.de>, <linux-kernel@vger.kernel.org>,
<hpa@zytor.com>
Subject: Re: [PATCH] x86-64: more fixes and cleanup to AMD Fam10 MMCONF enabling
Date: Fri, 05 Nov 2010 13:13:02 +0000 [thread overview]
Message-ID: <4CD410EE0200007800020BBF@vpn.id2.novell.com> (raw)
In-Reply-To: <20101105130710.GA32266@alberich.amd.com>
>>> On 05.11.10 at 14:07, Andreas Herrmann <herrmann.der.user@googlemail.com>
wrote:
> On Fri, Nov 05, 2010 at 10:59:10AM +0000, Jan Beulich wrote:
>> Unfortunately it turned out the original code had more issues: We want
>> to place the region above 4G in any case (even if TOM2 isn't enabled
>> or invalid), and the base mask definition was improperly typed (thus
>
> I am just curios. Do you actually have access to a system where TOM2
> isn't properly configured?
No - but since it was relatively obvious that the TOM2-not-set case
needed correction, it seemed simple and reasonable to also adjust
the TOM2-set-to-below-4G case.
Jan
next prev parent reply other threads:[~2010-11-05 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 10:59 Jan Beulich
2010-11-05 13:07 ` Andreas Herrmann
2010-11-05 13:13 ` Jan Beulich [this message]
2010-11-05 17:51 ` Yinghai Lu
2010-11-08 8:04 ` Jan Beulich
2010-11-10 19:22 ` Yinghai Lu
2010-11-08 16:13 ` H. Peter Anvin
2010-11-08 16:43 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD410EE0200007800020BBF@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=herrmann.der.user@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®