From: Dzianis Kahanovich <mahatma@bspu.unibel.by>
To: Dan Carpenter <error27@gmail.com>,
mahatma@eu.by, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] viafb: I2C/DDC LCD detection for VIA framebuffer
Date: Mon, 22 Nov 2010 16:24:19 +0200 [thread overview]
Message-ID: <4CEA7D13.9070602@bspu.unibel.by> (raw)
In-Reply-To: <20101122135939.GA8882@bicker>
Sorry for mistake. I sure to remove "const" but revert to older code later. I
repost fixed patch ("v2") to avoid formal problems. Sorry.
Dan Carpenter wrote:
> On Mon, Nov 22, 2010 at 02:31:55PM +0200, Dzianis Kahanovich wrote:
>> +static void via_i2c_detect(void)
>> +{
>> + const u8 *edid;
> ^^^^^
>
>> +free_edid:
>> + kfree(edid);
> ^^^^^^^^^^^
>
> That probably shouldn't be const.
>
>> + if (n > 1)
>> + break;
>> + }
>> +}
>> +
>>
>
> regards,
> dan carpenter
>
>
--
WBR, Dzianis Kahanovich AKA Denis Kaganovich, http://mahatma.bspu.unibel.by/
prev parent reply other threads:[~2010-11-22 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 12:31 Dzianis Kahanovich
2010-11-22 13:59 ` Dan Carpenter
2010-11-22 14:24 ` Dzianis Kahanovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA7D13.9070602@bspu.unibel.by \
--to=mahatma@bspu.unibel.by \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahatma@eu.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®