From: Warner Losh <imp@bsdimp.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Felipe Balbi <balbi@ti.com>,
gregkh@linuxfoundation.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Sourav Poddar <sourav.poddar@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property.
Date: Tue, 7 Aug 2012 11:23:40 -0600 [thread overview]
Message-ID: <4CEA7FE1-B4B7-4702-BD94-C04154014763@bsdimp.com> (raw)
In-Reply-To: <20120807105225.GT16861@opensource.wolfsonmicro.com>
On Aug 7, 2012, at 4:52 AM, Mark Brown wrote:
> On Tue, Aug 07, 2012 at 08:43:44AM +0300, Felipe Balbi wrote:
>> On Mon, Aug 06, 2012 at 04:42:14PM +0100, Mark Brown wrote:
>
>>> It's good practice to have an explict compatible string even if the
>>> default happens to work in order to avoid any name clashes.
>
>> of_i2c.c makes no use whatsoever of the compatible string. See that it
>> will build an i2c_boardinfo and register a new device. That compatible
>
> If that's all that's done it seems like a bug frankly, certainly based
> on previous discussions it ought to be. There are collisions out there,
> they've just happened to not bite us yet
Also keep in mind that the device tree is supposed to be a description of the hardware, and different implementations of the device tree may use the compatible string.
Warner
prev parent reply other threads:[~2012-08-07 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 9:28 Sourav Poddar
2012-08-06 9:30 ` Felipe Balbi
2012-08-06 15:42 ` Mark Brown
2012-08-07 5:43 ` Felipe Balbi
2012-08-07 10:52 ` Mark Brown
2012-08-07 17:23 ` Warner Losh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEA7FE1-B4B7-4702-BD94-C04154014763@bsdimp.com \
--to=imp@bsdimp.com \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®