From: "Jan Beulich" <JBeulich@novell.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: <mingo@elte.hu>, <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: fix section mismatch in LAPIC initialization
Date: Tue, 04 Jan 2011 08:42:14 +0000 [thread overview]
Message-ID: <4D22EB76020000780002A23D@vpn.id2.novell.com> (raw)
In-Reply-To: <4D22159C.6080402@zytor.com>
>>> On 03.01.11 at 19:29, "H. Peter Anvin" <hpa@zytor.com> wrote:
> On 01/03/2011 07:03 AM, Jan Beulich wrote:
>> Doing things conditionally upon spm_processor_id() being zero is
>> generally a bad idea, as this means CPU 0 cannot be offlined and
>> brought back online later again. While there may be other places where
>> this is done, I think adding more of those should be avoided so that
>> some day SMP really becomes "symmetrical".
>>
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> The description doesn't really match the subject line...
The subject, imo, doesn't need further explanation. The description
was meant to explain why the function gets broken up rather than
just fiddling with other (called) functions' annotations. Are you
suggesting to drop the description altogether?
Jan
prev parent reply other threads:[~2011-01-04 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 15:03 Jan Beulich
2011-01-03 18:29 ` H. Peter Anvin
2011-01-04 8:42 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D22EB76020000780002A23D@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®