From: David Daney <ddaney@caviumnetworks.com>
To: John Stultz <john.stultz@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Thomas Gleixner <tglx@linutronix.de>
Subject: RTC seems broken on 2.6.38-rc1 for RTCs lacking alarms.
Date: Thu, 20 Jan 2011 12:51:29 -0800 [thread overview]
Message-ID: <4D38A051.2010301@caviumnetworks.com> (raw)
The hwclock program on my MIPS Debian GNU/Linux 5.0 system quit
working with 2.6.38-rc1.
This particular ds1307 has no interrupt connection, so the alarm
feature cannot be used. Because of this the
rtc_class_ops.set_alarm() function always will return -EINVAL
This problem appears to be related to commits:
042620a RTC: Remove UIE emulation
6610e08 RTC: Rework RTC code to use timerqueue for events
My system uses a ds1307 RTC which still works as evidenced by the
kernel boot messages.
.
.
.
rtc-ds1307 0-0068: setting system clock to 2011-01-20 19:58:48 UTC
(1295553528)
.
.
.
But hwclock now fails here is some nice strace output:
.
.
.
open("/dev/rtc0", O_RDONLY|O_LARGEFILE) = 3
ioctl(3, PRESTO_GETMOUNT or RTC_UIE_ON, 0) = 0
_newselect(4, [3], NULL, NULL, {5, 0}) = 0 (Timeout)
write(2, "select() to /dev/rtc0 to wait for"..., 55select() to /dev/rtc0
to wait for clock tick timed out
) = 55
ioctl(3, PRESTO_SETPID or RTC_UIE_OFF, 0) = 0
close(3) = 0
exit_group(1) = ?
The hwclock program is asking to put the clock in UIE mode and then
does a select() on it. Since the alarm doesn't work, the select times out.
Previously the ioctl(RTC_UIE_ON) would return EINVAL:
.
.
.
open("/dev/rtc0", O_RDONLY|O_LARGEFILE) = 3
ioctl(3, PRESTO_GETMOUNT or RTC_UIE_ON, 0) = -1 EINVAL (Invalid argument)
ioctl(3, PRESTO_SETOPT or RTC_RD_TIME, {tm_sec=48, tm_min=41,
tm_hour=20, tm_mday=20, tm_mon=0, tm_year=111, ...}) = 0
ioctl(3, PRESTO_SETOPT or RTC_RD_TIME, {tm_sec=48, tm_min=41,
tm_hour=20, tm_mday=20, tm_mon=0, tm_year=111, ...}) = 0
.
.
.
The problem seems to be that rtc_update_irq_enable() no longer returns
-EINVAL when it cannot set the alarm.
David Daney
next reply other threads:[~2011-01-20 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 20:51 David Daney [this message]
2011-01-20 21:16 ` John Stultz
2011-01-20 21:24 ` Geert Uytterhoeven
2011-01-20 22:23 ` John Stultz
2011-01-20 22:54 ` David Daney
2011-01-21 10:48 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D38A051.2010301@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=a.zummo@towertech.it \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome