From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/20] pata_oldpiix: add locking for parallel scanning
Date: Thu, 10 Feb 2011 17:28:22 +0300 [thread overview]
Message-ID: <4D53F606.8020505@ru.mvista.com> (raw)
In-Reply-To: <20110208122519.19110.76776.sendpatchset@linux-mhg7.site>
Hello.
On 08-02-2011 15:25, Bartlomiej Zolnierkiewicz wrote:
[...]
> Add an extra locking for parallel scanning.
> This is similar change as commit 60c3be3 for ata_piix host driver
Linus asks to also specify the commit summary in parens.
> and while pata_oldpiix doesn't enable parallel scan yet the race
> could probably also be triggered by requesting re-scanning of both
> ports at the same time using SCSI sysfs interface.
> Fix documentation while at it.
> Acked-by: Alan Cox <alan@linux.intel.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
[...]
> diff --git a/drivers/ata/pata_oldpiix.c b/drivers/ata/pata_oldpiix.c
> index 433d2fc..845ede1 100644
> --- a/drivers/ata/pata_oldpiix.c
> +++ b/drivers/ata/pata_oldpiix.c
> @@ -1,7 +1,8 @@
> /*
> - * pata_oldpiix.c - Intel PATA/SATA controllers
> + * pata_oldpiix.c - older Intel PATA controllers
I'd say "controller", since there's only one. :-)
WBR, Sergei
next prev parent reply other threads:[~2011-02-10 14:29 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 12:23 [PATCHSET] ata: rework support for PIIX-alike PATA controllers Bartlomiej Zolnierkiewicz
2011-02-08 12:23 ` [PATCH 01/20] ata_piix: SITRE handling fix Bartlomiej Zolnierkiewicz
2011-02-08 13:04 ` Alan Cox
2011-02-08 13:02 ` Bartlomiej Zolnierkiewicz
2011-02-08 12:23 ` [PATCH 02/20] ata_piix: unify code for programming PIO and MWDMA timings Bartlomiej Zolnierkiewicz
2011-02-20 13:36 ` Sergei Shtylyov
2011-02-20 18:59 ` Alan Cox
2011-02-20 20:42 ` Sergei Shtylyov
2011-02-20 21:07 ` Alan Cox
2011-02-21 11:38 ` Sergei Shtylyov
2011-02-21 11:53 ` Sergei Shtylyov
2011-02-21 12:00 ` Alan Cox
2011-02-21 11:58 ` Alan Cox
2011-02-21 11:59 ` Sergei Shtylyov
2011-02-08 12:23 ` [PATCH 03/20] pata_efar: fix register naming used in efar_set_piomode() Bartlomiej Zolnierkiewicz
2011-02-08 12:24 ` [PATCH 04/20] pata_efar: unify code for programming PIO and MWDMA timings Bartlomiej Zolnierkiewicz
2011-02-20 14:32 ` Sergei Shtylyov
2011-02-08 12:24 ` [PATCH 05/20] pata_efar: always program master_data before slave_data Bartlomiej Zolnierkiewicz
2011-02-08 13:07 ` Alan Cox
2011-02-08 13:16 ` Bartlomiej Zolnierkiewicz
2011-02-08 13:25 ` Alan Cox
2011-02-08 13:28 ` Bartlomiej Zolnierkiewicz
2011-02-08 13:39 ` Alan Cox
2011-02-08 13:57 ` Bartlomiej Zolnierkiewicz
2011-02-08 14:12 ` Alan Cox
2011-02-08 14:32 ` Bartlomiej Zolnierkiewicz
2011-02-08 13:38 ` Sergei Shtylyov
2011-02-19 9:25 ` Bartlomiej Zolnierkiewicz
2011-02-19 16:48 ` Alan Cox
2011-02-20 10:38 ` Bartlomiej Zolnierkiewicz
2011-02-20 11:36 ` Alan Cox
2011-02-21 20:06 ` Jeff Garzik
2011-02-22 9:19 ` Bartlomiej Zolnierkiewicz
2011-02-22 11:14 ` Alan Cox
2011-02-23 8:45 ` Bartlomiej Zolnierkiewicz
2011-02-23 8:53 ` Bartlomiej Zolnierkiewicz
2011-02-23 10:17 ` Bartlomiej Zolnierkiewicz
2011-02-23 9:14 ` Alan Cox
2011-02-23 10:28 ` Bartlomiej Zolnierkiewicz
2011-02-23 10:36 ` Alan Cox
2011-02-24 17:53 ` Alan Cox
2011-02-10 14:23 ` Sergei Shtylyov
2011-02-10 17:14 ` Bartlomiej Zolnierkiewicz
2011-02-10 17:55 ` Sergei Shtylyov
2011-02-08 12:24 ` [PATCH 06/20] pata_it8213: fix register naming used in it8213_set_piomode() Bartlomiej Zolnierkiewicz
2011-02-08 12:24 ` [PATCH 07/20] pata_it8213: unify code for programming PIO and MWDMA timings Bartlomiej Zolnierkiewicz
2011-02-20 14:37 ` Sergei Shtylyov
2011-02-08 12:24 ` [PATCH 08/20] pata_it8213: add UDMA100 and UDMA133 support Bartlomiej Zolnierkiewicz
2011-02-08 12:24 ` [PATCH 09/20] pata_oldpiix: unify code for programming PIO and MWDMA timings Bartlomiej Zolnierkiewicz
2011-02-20 14:52 ` Sergei Shtylyov
2011-02-08 12:24 ` [PATCH 10/20] pata_radisys: " Bartlomiej Zolnierkiewicz
2011-02-20 15:01 ` Sergei Shtylyov
2011-02-08 12:24 ` [PATCH 11/20] pata_rdc: " Bartlomiej Zolnierkiewicz
2011-02-08 12:25 ` [PATCH 12/20] pata_rdc: parallel scanning needs an extra locking Bartlomiej Zolnierkiewicz
2011-02-20 15:04 ` Sergei Shtylyov
2011-02-08 12:25 ` [PATCH 13/20] pata_rdc: add Power Management support Bartlomiej Zolnierkiewicz
2011-02-08 12:25 ` [PATCH 14/20] pata_oldpiix: add locking for parallel scanning Bartlomiej Zolnierkiewicz
2011-02-10 14:28 ` Sergei Shtylyov [this message]
2011-02-08 12:25 ` [PATCH 15/20] pata_oldpiix: enable parallel scan Bartlomiej Zolnierkiewicz
2011-02-08 12:25 ` [PATCH 16/20] ata_piix: add EFAR SLC90E66 support Bartlomiej Zolnierkiewicz
2011-02-08 13:13 ` Alan Cox
2011-02-08 13:27 ` Bartlomiej Zolnierkiewicz
2011-02-08 13:38 ` Alan Cox
2011-02-08 14:01 ` Bartlomiej Zolnierkiewicz
2011-02-08 12:25 ` [PATCH 17/20] ata_piix: add IT8213 support Bartlomiej Zolnierkiewicz
2011-02-08 12:25 ` [PATCH 18/20] ata_piix: add RDC support Bartlomiej Zolnierkiewicz
2011-02-08 12:25 ` [PATCH 19/20] ata_piix: add Intel old PIIX support Bartlomiej Zolnierkiewicz
2011-02-08 12:26 ` [PATCH 20/20] ata_piix: add Radisys R82600 support Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D53F606.8020505@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome