From: Xinghui Li <korantwork@gmail.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>, <mchehab@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
Xinghui Li <korantli@tencent.com>, loydlv <loydlv@tencent.com>
Subject: Re: [PATCH] media:cec:fix double free and uaf issue when cancel data during noblocking
Date: Thu, 19 Jan 2023 12:49:23 +0800 [thread overview]
Message-ID: <4D54942F-92F0-429D-9F54-3D8F7705D576@gmail.com> (raw)
In-Reply-To: <b1a8593b-b4f3-b943-39db-ed17679e32cb@xs4all.nl>
在 2023/1/18 18:18，“Hans Verkuil”<hverkuil-cisco@xs4all.nl <mailto:hverkuil-cisco@xs4all.nl>> 写入:
>...while this free is called if data->blocking is true. (see the 'if (!block) return 0;'
>further up).
Do you mean this code?
/* All done if we don't need to block waiting for completion */
if (!block)
return 0;
I notice this part code. But I'm not sure if 'block' will be modified in other sync operations.
So I sent this patch for community to review.
>So I have my doubts if this patch actually addresses the correct issue.
>Do you have an actual debug trace of the UAF? Or even better, code to reproduce
>this issue.
And we found this issue by the code scanning tool developed by loydlv and filtered from 200 issue by human.
So it could be the none-issue. If so, I hope I didn't waste too much of your time. __
next prev parent reply other threads:[~2023-01-19 4:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 12:37 korantwork
2023-01-18 10:18 ` Hans Verkuil
2023-01-19 4:49 ` Xinghui Li [this message]
2023-01-19 7:46 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D54942F-92F0-429D-9F54-3D8F7705D576@gmail.com \
--to=korantwork@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=korantli@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loydlv@tencent.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®