mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin Povišer" <povik+lin@cutebit.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Vinod Koul <vkoul@kernel.org>,
	linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] dmaengine: apple-admac: Fix build on 32-bit/non-LPAE platforms
Date: Wed, 15 Jun 2022 14:07:12 +0200	[thread overview]
Message-ID: <4D5BB835-5DF0-4BBB-B073-A77F1A96EA19@cutebit.org> (raw)
In-Reply-To: <20220614074915.1443629-1-geert@linux-m68k.org>


> On 14. 6. 2022, at 9:49, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> 
> If CONFIG_PHYS_ADDR_T_64BIT is not set:
> 
>    drivers/dma/apple-admac.c: In function ‘admac_cyclic_write_one_desc’:
>    drivers/dma/apple-admac.c:213:22: error: right shift count >= width of type [-Werror=shift-count-overflow]
>      213 |  writel_relaxed(addr >> 32,       ad->base + REG_DESC_WRITE(channo));
>          |                      ^~
> 
> Fix this by using the {low,upp}er_32_bits() helper macros to obtain the
> address parts.
> 
> Reported-by: noreply@ellerman.id.au
> Fixes: b127315d9a78c011 ("dmaengine: apple-admac: Add Apple ADMAC driver")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks! (TIL about the lower/upper_32_bits helpers)

Acked-by: Martin Povišer <povik+lin@cutebit.org>


  reply	other threads:[~2022-06-15 12:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  7:49 Geert Uytterhoeven
2022-06-15 12:07 ` Martin Povišer [this message]
2022-06-16 13:44 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5BB835-5DF0-4BBB-B073-A77F1A96EA19@cutebit.org \
    --to=povik+lin@cutebit.org \
    --cc=alyssa@rosenzweig.io \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=sven@svenpeter.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®