From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755992Ab2EGLSN (ORCPT ); Mon, 7 May 2012 07:18:13 -0400 Received: from mga03.intel.com ([143.182.124.21]:51389 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753330Ab2EGLSM convert rfc822-to-8bit (ORCPT ); Mon, 7 May 2012 07:18:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="139763651" From: "R, Durgadoss" To: "Kirill A. Shutemov" CC: "Yu, Fenghua" , Guenter Roeck , Andi Kleen , Jean Delvare , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH, v3] hwmon: coretemp: use list instead of fixed size array for temp data Thread-Topic: [PATCH, v3] hwmon: coretemp: use list instead of fixed size array for temp data Thread-Index: AQHNLDzUnmQOFAJAQkaoequKj7BmNpa+J5TQ//+noQCAAF4nwA== Date: Mon, 7 May 2012 11:17:57 +0000 Message-ID: <4D68720C2E767A4AA6A8796D42C8EB591184EF@BGSMSX102.gar.corp.intel.com> References: <1336386848-31041-1-git-send-email-kirill.shutemov@linux.intel.com> <4D68720C2E767A4AA6A8796D42C8EB591184C1@BGSMSX102.gar.corp.intel.com> <20120507110959.GA7339@otc-wbsnb-06> In-Reply-To: <20120507110959.GA7339@otc-wbsnb-06> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, [snip.] > > > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c > > > index b9d5123..fa082d5 100644 > > > --- a/drivers/hwmon/coretemp.c > > > +++ b/drivers/hwmon/coretemp.c > > > @@ -36,6 +36,8 @@ > > > #include > > > #include > > > #include > > > +#include > > > +#include > > > > I think we don't need to include kref.h now :-) > > Right. :( > Guenter, should I resend the patch or you can fix this on apply? > > > > > BTW, at some places, looks like we are using 'tdata' obtained from > get_temp_data, > > without checking for NULL values. Other than that, looks Ok for me. > > Do you mean sysfs show methods? It should never be NULL there. If it's > NULL, we have bug (race?) somewhere. > Yes agree with you. That's fine then. > > Acked-by: Durgadoss R > > Thanks. You are welcome :-) Thanks, Durga