From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757502Ab3AIJMg (ORCPT ); Wed, 9 Jan 2013 04:12:36 -0500 Received: from mga14.intel.com ([143.182.124.37]:40127 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756879Ab3AIJMd convert rfc822-to-8bit (ORCPT ); Wed, 9 Jan 2013 04:12:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,436,1355126400"; d="scan'208";a="189209865" From: "R, Durgadoss" To: Greg KH CC: "Zhang, Rui" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "eduardo.valentin@ti.com" , "hongbo.zhang@linaro.org" , "wni@nvidia.com" Subject: RE: [PATCH 7/9] Thermal: Make PER_ZONE values configurable Thread-Topic: [PATCH 7/9] Thermal: Make PER_ZONE values configurable Thread-Index: AQHN7Kc47pM6EnqmX0KcFhxlvJmff5g946UAgALUpnA= Date: Wed, 9 Jan 2013 09:12:29 +0000 Message-ID: <4D68720C2E767A4AA6A8796D42C8EB59257F01@BGSMSX101.gar.corp.intel.com> References: <1357542806-20449-1-git-send-email-durgadoss.r@intel.com> <1357542806-20449-8-git-send-email-durgadoss.r@intel.com> <20130107192414.GC4465@kroah.com> In-Reply-To: <20130107192414.GC4465@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Tuesday, January 08, 2013 12:54 AM > To: R, Durgadoss > Cc: Zhang, Rui; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; > eduardo.valentin@ti.com; hongbo.zhang@linaro.org; wni@nvidia.com > Subject: Re: [PATCH 7/9] Thermal: Make PER_ZONE values configurable > > On Mon, Jan 07, 2013 at 12:43:24PM +0530, Durgadoss R wrote: > > This patch makes MAX_SENSORS_PER_ZONE and > > MAX_CDEVS_PER_ZONE values configurable. The > > default value is 1, and range is 1-12. > > Why would we ever want to change this? Why make this configurable at > all, how is a distro supposed to set this value? > > Shouldn't it be specified from the driver itself? These are platform level parameters, that can differ for various platforms. (Mostly due to board design and thermistor layouts). Stand-alone thermal sensor drivers are not (need not be) aware of these values. That's why these values are made configurable. Thanks, Durga