From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Michael Spang <mspang@csclub.uwaterloo.ca>
Cc: Nicolas Pitre <nico@fluxnic.net>,
Russell King <linux@arm.linux.org.uk>,
Lennert Buytenhek <kernel@wantstofly.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: Enable TS-78XX features in unknown revisions
Date: Sat, 05 Mar 2011 15:30:58 +0300 [thread overview]
Message-ID: <4D722D02.5090504@ru.mvista.com> (raw)
In-Reply-To: <1299299957-13018-2-git-send-email-mspang@csclub.uwaterloo.ca>
Hello.
On 05-03-2011 7:39, Michael Spang wrote:
> When the manufacturer increases the revision number the platform
> devices for the RTC, NAND, and RNG disappear. We should assume
> new revisions have these devices instead of assuming they do not.
> Signed-off-by: Michael Spang<mspang@csclub.uwaterloo.ca>
> ---
> arch/arm/mach-orion5x/ts78xx-setup.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
> diff --git a/arch/arm/mach-orion5x/ts78xx-setup.c b/arch/arm/mach-orion5x/ts78xx-setup.c
> index 7bed418..13d1fc5 100644
> --- a/arch/arm/mach-orion5x/ts78xx-setup.c
> +++ b/arch/arm/mach-orion5x/ts78xx-setup.c
> @@ -343,9 +343,11 @@ static void ts78xx_fpga_supports(void)
> ts78xx_fpga.supports.ts_rng.present = 1;
> break;
> default:
> - ts78xx_fpga.supports.ts_rtc.present = 0;
> - ts78xx_fpga.supports.ts_nand.present = 0;
> - ts78xx_fpga.supports.ts_rng.present = 0;
> + printk(KERN_WARN "Unrecognized TS-78XX FPGA ID 0x%02x",
Use pr_warning() or pr_warn().
WBR, Sergei
next prev parent reply other threads:[~2011-03-05 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 4:39 [PATCH 1/2] ARM: Add TS-7800 revisions 6-9 Michael Spang
2011-03-05 4:39 ` [PATCH 2/2] ARM: Enable TS-78XX features in unknown revisions Michael Spang
2011-03-05 4:50 ` [PATCH v2 " Michael Spang
2011-03-05 12:30 ` Sergei Shtylyov [this message]
2011-03-05 4:59 ` [PATCH 1/2] ARM: Add TS-7800 revisions 6-9 Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D722D02.5090504@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=kernel@wantstofly.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mspang@csclub.uwaterloo.ca \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®