From: Kumar Gala <galak@kernel.crashing.org>
To: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
gregkh@suse.de, Kai Jiang <Kai.Jiang@freescale.com>
Subject: Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems
Date: Mon, 17 Oct 2011 11:00:55 -0500 [thread overview]
Message-ID: <4D73F261-3795-4F71-9921-568C1B9F06E0@kernel.crashing.org> (raw)
In-Reply-To: <20111014183144.GD28556@local>
On Oct 14, 2011, at 1:31 PM, Hans J. Koch wrote:
> On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote:
>> From: Kai Jiang <Kai.Jiang@freescale.com>
>>
>> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
>> extend the width of 'addr' in struct uio_mem. Numerous platforms like
>> embedded PPC, ARM, and X86 have support for systems with larger physical
>> address than logical.
>>
>> Since 'addr' may contain a physical, logical, or virtual address the
>> easiest solution is to just change the type to 'phys_addr_t' which
>> should always be greater than or equal to the sizeof(void *) such that
>> it can properly hold any of the address types.
>>
>> For physical address we can support up to a 44-bit physical address on a
>> typical 32-bit system as we utilize remap_pfn_range() for the mapping of
>> the memory region and pfn's are represnted by shifting the address by
>> the page size (typically 4k).
>>
>> Signed-off-by: Kai Jiang <Kai.Jiang@freescale.com>
>> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>
> Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>
>
> That looks good to me. There's an unnecessary cast (see below), but I fixed that
> on the way.
>
> Greg, please pull this from branch uio-for-gregkh from
>
> git://hansjkoch.de/git/linux-hjk
>
> Thanks,
> Hans
I think removing that cast is wrong:
drivers/uio/uio.c: In function 'uio_vma_fault':
drivers/uio/uio.c:637:26: warning: cast to pointer from integer of different size
- k
next prev parent reply other threads:[~2011-10-17 16:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 15:50 Kumar Gala
2011-10-14 18:31 ` Hans J. Koch
2011-10-14 18:36 ` Greg KH
2011-10-14 18:46 ` Hans J. Koch
2011-10-17 16:00 ` Kumar Gala [this message]
2011-10-17 17:18 ` Hans J. Koch
2011-10-17 18:03 ` Hans J. Koch
2011-10-17 18:23 ` Greg KH
2011-10-17 18:50 ` Hans J. Koch
-- strict thread matches above, loose matches on Subject: below --
2011-10-12 14:35 Kumar Gala
2011-10-12 15:32 ` Hans J. Koch
2011-10-12 16:07 ` Kumar Gala
2011-10-12 16:15 ` Geert Uytterhoeven
2011-10-13 14:10 ` Tabi Timur-B04825
2011-10-13 14:25 ` Geert Uytterhoeven
2011-10-13 14:35 ` Timur Tabi
2011-10-12 16:16 ` Hans J. Koch
2011-10-12 16:19 ` Hans J. Koch
2011-10-12 18:40 ` Kumar Gala
2011-10-12 20:23 ` Hans J. Koch
2011-10-12 20:58 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D73F261-3795-4F71-9921-568C1B9F06E0@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=Kai.Jiang@freescale.com \
--cc=gregkh@suse.de \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®