From: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org, h.mitake@gmail.com,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] perf lock: clean the options for perf record
Date: Thu, 10 Mar 2011 01:41:00 +0900 [thread overview]
Message-ID: <4D77AD9C.4080407@dcl.info.waseda.ac.jp> (raw)
In-Reply-To: <20110304142113.GC1972@nowhere>
On 2011年03月04日 23:21, Frederic Weisbecker wrote:
> On Fri, Mar 04, 2011 at 02:58:19PM +0100, Peter Zijlstra wrote:
>> On Fri, 2011-03-04 at 14:56 +0100, Frederic Weisbecker wrote:
>>> lockstat is a global measurement since the boot.
>>
>> You can reset lockstat at any given time.
>
> Event though, that's still a global profiling. You can't have a per
> process or thread granularity.
>
> Or even more precise context for some future feature in perf that
> I have in mind and would like to implement soon, like counting/sampling
> an event only between two others. More exactly having two lists for
> each event:
>
> * activate
> * deactivate
>
> Those on the first list activate the target event when they overflow. (->start() )
> Those on the second list deactivate .... (->stop() )
>
> With events in activate and deactivate in the same context than the target,
> locking and permissions should be kept simple. Locking especially shouldn't be
> needed in the fast path. Then if that's needed we could think about a cross
> context things later.
>
> Plus an attr->start_state that decides if the first ->add() made is made
> with PERF_EF_STAT or not. (We then need to keep track of some activated/deactivated
> state across schedules).
>
> That's in fact the exclude_irq and exclude_softirq idea extended to any kind
> of existing event.
>
Do you mean that the event dropping in perf_tp_event_match() should be
extended for filtering hardirq and softirq? If so, it seems good.
I'd like to measure the effectiveness of it.
next prev parent reply other threads:[~2011-03-09 16:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 15:28 Hitoshi Mitake
2011-02-22 15:30 ` Hitoshi Mitake
2011-02-22 15:43 ` Peter Zijlstra
2011-02-22 18:22 ` Frederic Weisbecker
2011-02-23 4:17 ` Hitoshi Mitake
2011-02-24 15:46 ` Hitoshi Mitake
2011-02-24 16:50 ` Frederic Weisbecker
2011-02-25 17:10 ` Hitoshi Mitake
2011-02-28 15:00 ` [PATCH] lockstat: export data in python expression Hitoshi Mitake
2011-02-28 18:07 ` Peter Zijlstra
2011-02-28 23:48 ` Hitoshi Mitake
2011-03-04 14:08 ` Steven Rostedt
2011-03-01 14:55 ` [PATCH] perf lock: clean the options for perf record Frederic Weisbecker
2011-03-04 9:41 ` Hitoshi Mitake
2011-03-04 13:56 ` Frederic Weisbecker
2011-03-04 13:58 ` Peter Zijlstra
2011-03-04 14:21 ` Frederic Weisbecker
2011-03-09 16:41 ` Hitoshi Mitake [this message]
2011-03-04 14:37 ` Steven Rostedt
2011-03-04 14:41 ` Frederic Weisbecker
2011-03-05 17:20 ` Hitoshi Mitake
2011-03-05 17:14 ` Hitoshi Mitake
2011-02-22 18:09 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D77AD9C.4080407@dcl.info.waseda.ac.jp \
--to=mitake@dcl.info.waseda.ac.jp \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=h.mitake@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®