From: Knut Petersen <Knut_Petersen@t-online.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.de>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
jesse.barnes@intel.com, gregkh@suse.de,
linux-kernel@vger.kernel.org,
"David Müller" <d.mueller@elsoft.ch>
Subject: Re: [BUG][2.6.38] IRQ Lock Inversion / i915 fails
Date: Fri, 18 Mar 2011 00:33:28 +0100 [thread overview]
Message-ID: <4D829A48.7020408@t-online.de> (raw)
In-Reply-To: <AANLkTim=R7GVDY0Nt-6q1mjO3vas-qRy7=VxqgWWtz_s@mail.gmail.com>
Am 17.03.2011 17:55, schrieb Linus Torvalds:
>
> Ok, so the lock inversion seems to be due to the sound/drivers/aloop.c
> file, where the function "loopback_pos_update()" gets called from
> within a softirq context. And it takes a lock (cable->lock) that is
> also taken unprotected by loopback_trigger(). So that's liable to
> deadlock as per lockdep. Jaroslav? Takashi?
Takashi Iwai already gave a solution for the irq inversion problem.
> The X problem seems to be something unrelated. You have those "GPU
> hung" messages, along with i2c/EDID problems. But the actual oops is
> at the very beginning of intel_release_load_detect_pipe(), here:
>
> 0: 55 push %ebp
> 1: 89 e5 mov %esp,%ebp
> 3: 57 push %edi
> 4: 89 cf mov %ecx,%edi
> 6: 56 push %esi
> 7: 53 push %ebx
> 8: 89 c3 mov %eax,%ebx
> a: 83 ec 0c sub $0xc,%esp
> d: 8b 00 mov (%eax),%eax
> f: 8b 73 20 mov 0x20(%ebx),%esi
> 12: 80 7b 30 00 cmpb $0x0,0x30(%ebx)
> 16: 8b 4b 28 mov 0x28(%ebx),%ecx
> 19: 89 45 f0 mov %eax,-0x10(%ebp)
> 1c:* 8b 86 e0 01 00 00 mov 0x1e0(%esi),%eax <-- trapping
> instruction
> 22: 89 45 ec mov %eax,-0x14(%ebp)
> 25: 74 2d je 0x54
> 27: c7 43 20 00 00 00 00 movl $0x0,0x20(%ebx)
> 2e: 89 f0 mov %esi,%eax
>
> where %esi is NULL. I think that is the "crtc->helper_private" load,
> and crtc is NULL.
>
> That code does look broken. The very same function explicitly sets
> crtc to NULL, so clearly it _can_ be NULL. That said, this is all old
> code. I suspect the thing that made it start trigger may be commit
> f5afcd3dd0dc ("drm/i915/crt: Check for a analog monitor in case of
> DVI-I"), which is the only real change to the crt_detect logic I can
> see.
>
Well, I think there are two i915 problems that are independent.
The i2c/edid thing might be related to the f5a...commit, but reverting
that commit alone does not help. i2c/edid error messages might be before
or after the "gpu hung" problem, Xorg seems to be able to cope with that.
But after a gpu lockup it's time to reboot.
If nobody has a better idea I'll try to bisect ... tomorrow.
cu,
Knut
next prev parent reply other threads:[~2011-03-17 23:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 9:40 Knut Petersen
2011-03-17 9:47 ` Knut Petersen
2011-03-17 16:55 ` Linus Torvalds
2011-03-17 17:15 ` Takashi Iwai
2011-03-17 17:33 ` Linus Torvalds
2011-03-17 20:05 ` Steven Rostedt
2011-03-17 23:12 ` Knut Petersen
2011-03-18 6:55 ` Takashi Iwai
2011-03-17 23:33 ` Knut Petersen [this message]
2011-03-18 16:08 ` Knut Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D829A48.7020408@t-online.de \
--to=knut_petersen@t-online.de \
--cc=chris@chris-wilson.co.uk \
--cc=d.mueller@elsoft.ch \
--cc=gregkh@suse.de \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome