mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: lkml <linux-kernel@vger.kernel.org>,
	torvalds <torvalds@linux-foundation.org>,
	lud <linux-usb@vger.kernel.org>, gregkh <greg@kroah.com>,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH] usb/serial: fix function args warnings, dropping *filp
Date: Sat, 02 Apr 2011 16:51:35 +0400	[thread overview]
Message-ID: <4D971BD7.5040203@ru.mvista.com> (raw)
In-Reply-To: <20110401180413.cb6e35fa.rdunlap@xenotime.net>

Hello.

On 02-04-2011 5:04, Randy Dunlap wrote:

> From: Randy Dunlap<randy.dunlap@oracle.com>

> Fix build warnings caused by removal of *filp arg in
> struct usb_serial_driver.
> These changes were missed somehow in commits
> 00a0d0d65b61241a718d0aee96f46b9a2d93bf26 and
> 60b33c133ca0b7c0b6072c87234b63fee6e80558.

    How about also specifying the commit summaries for the human readers?

> drivers/usb/serial/mct_u232.c:159: warning: initialization from incompatible pointer type
> drivers/usb/serial/opticon.c:627: warning: initialization from incompatible pointer type

> Signed-off-by: Randy Dunlap<randy.dunlap@oracle.com>
> Cc: Alan Cox<alan@linux.intel.com>

WBR, Sergei

  reply	other threads:[~2011-04-02 12:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-02  1:04 Randy Dunlap
2011-04-02 12:51 ` Sergei Shtylyov [this message]
2011-04-03 18:42   ` [PATCH v2] " Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D971BD7.5040203@ru.mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=alan@linux.intel.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome