From: Ryan Mallon <ryan@bluewatersys.com>
To: Greg KH <greg@kroah.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
adobriyan@gmail.com
Subject: Re: [PATCH 2/3] debugfs: move to new strtobool
Date: Tue, 26 Apr 2011 11:11:03 +1200 [thread overview]
Message-ID: <4DB5FF87.1060502@bluewatersys.com> (raw)
In-Reply-To: <20110425225437.GA31808@kroah.com>
On 04/26/2011 10:54 AM, Greg KH wrote:
> On Wed, Apr 20, 2011 at 10:33:22AM +0100, Jonathan Cameron wrote:
>> On 04/19/11 21:30, Ryan Mallon wrote:
>>> On 04/19/2011 11:43 PM, Jonathan Cameron wrote:
>>>> No functional changes requires that we eat errors from strtobool.
>>>> If people want to not do this, then it should be fixed at a later date.
>>>
>>> May as well fix it now or it will get forgotten about. A second patch on
>>> top of this can fix the bug.
>> What worries me about this 'fix' is that it may well break some 'interesting'
>> bit of userspace code. It would count as a userspace api change, be it
>> a fairly minor one.
>>
>> Greg, do you thing it's worth returning an error on a non bool value?
>
> No one has ever complained about it, so I doubt it's a big issue.
Probably because nobody checks for errors in user space :-p
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2011-04-25 23:11 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a>
2011-04-19 11:43 ` [PATCH 0/3 V3] Introduce strtobool (previously usr_strtobool) Jonathan Cameron
2011-04-19 11:43 ` [PATCH 1/3] Add a strtobool function matching semantics of existing in kernel equivalents Jonathan Cameron
2011-04-19 20:28 ` Ryan Mallon
2011-04-19 11:43 ` [PATCH 2/3] debugfs: move to new strtobool Jonathan Cameron
2011-04-19 20:30 ` Ryan Mallon
2011-04-20 9:33 ` Jonathan Cameron
2011-04-25 22:54 ` Greg KH
2011-04-25 23:11 ` Ryan Mallon [this message]
2011-04-19 11:43 ` [PATCH 3/3] params.c: Use new strtobool function to process boolean inputs Jonathan Cameron
2012-07-05 6:28 ` [PATCH] mm/memcg: replace inexistence move_lock_page_cgroup() by move_lock_mem_cgroup() in comment Wanpeng Li
2012-07-09 4:37 ` Kamezawa Hiroyuki
2012-07-11 13:24 ` [PATCH RFC] mm/memcg: calculate max hierarchy limit number instead of min Wanpeng Li
2012-07-11 13:47 ` Michal Hocko
2012-07-12 9:32 ` Wanpeng Li
2012-07-12 10:18 ` Michal Hocko
2012-07-19 6:07 ` Kamezawa Hiroyuki
2012-07-19 6:30 ` Wanpeng Li
2012-07-18 3:05 ` [PATCH] mm/memcg: wrap mem_cgroup_from_css function Wanpeng Li
2012-07-18 21:36 ` Andrew Morton
2012-07-19 1:31 ` Wanpeng Li
2012-07-19 9:14 ` Kirill A. Shutemov
2012-07-19 9:23 ` Wanpeng Li
2012-07-19 9:29 ` Kirill A. Shutemov
[not found] ` <20120719093835.GA3776@shangw.(null)>
2012-07-19 9:45 ` Kirill A. Shutemov
2012-07-19 10:19 ` Wanpeng Li
2013-08-13 13:31 ` [PATCH V2 00/35] CPUFreq: Implement light weight ->target(): for 3.13 Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 01/35] cpufreq: Implement light weight ->target_index() routine Viresh Kumar
2013-08-18 10:41 ` amit daniel kachhap
2013-08-13 13:32 ` [PATCH V2 02/35] cpufreq: remove CONFIG_CPU_FREQ_TABLE Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 03/35] cpufreq: acpi: Covert to light weight ->target_index() routine Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 04/35] cpufreq: arm_big_little: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 05/35] cpufreq: at32ap: " Viresh Kumar
2013-08-14 8:00 ` Hans-Christian Egtvedt
2013-08-13 13:32 ` [PATCH V2 06/35] cpufreq: blackfin: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 07/35] cpufreq: cpu0: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 08/35] cpufreq: cris: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 09/35] cpufreq: davinci: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 10/35] cpufreq: dbx500: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 11/35] cpufreq: e_powersaver: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 12/35] cpufreq: elanfreq: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 13/35] cpufreq: exynos: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 14/35] cpufreq: ia64: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 15/35] cpufreq: imx6q: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 16/35] cpufreq: kirkwood: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 17/35] cpufreq: longhaul: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 18/35] cpufreq: loongson2: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 19/35] cpufreq: maple: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 20/35] cpufreq: omap: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 21/35] cpufreq: p4: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 22/35] cpufreq: pasemi: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 23/35] cpufreq: pmac32: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 24/35] cpufreq: powernow: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 25/35] cpufreq: ppc: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 26/35] cpufreq: pxa: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 27/35] cpufreq: s3c2416: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 28/35] cpufreq: s3c64xx: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 29/35] cpufreq: s5pv210: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 30/35] cpufreq: sa11x0: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 31/35] cpufreq: sc520: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 32/35] cpufreq: sparc: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 33/35] cpufreq: SPEAr: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 34/35] cpufreq: speedstep: " Viresh Kumar
2013-08-13 13:32 ` [PATCH V2 35/35] cpufreq: tegra: " Viresh Kumar
2013-08-13 13:46 ` [PATCH V2 00/35] CPUFreq: Implement light weight ->target(): for 3.13 Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB5FF87.1060502@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=adobriyan@gmail.com \
--cc=greg@kroah.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome