From: "Jan Beulich" <JBeulich@novell.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: <mingo@elte.hu>, <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86-64: re-use kernel/syscall_table_32.S in ia32/ia32entry.S
Date: Wed, 27 Apr 2011 17:02:55 +0100 [thread overview]
Message-ID: <4DB85A4F020000780003E6F7@vpn.id2.novell.com> (raw)
In-Reply-To: <4DB83946.609@zytor.com>
>>> On 27.04.11 at 17:41, "H. Peter Anvin" <hpa@zytor.com> wrote:
> On 04/27/2011 08:33 AM, Jan Beulich wrote:
>> This requires a little bit of renaming, and a (much shorter than the
>> original full table) set of #define-s for those table entries where
>> native and compat mode entries differ.
>>
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>
> Hm... not 100% sure I think this is an improvement, partly because it
> creates "action at a distance" -- you now have to look in two separate
> places to find out what actually happens with a system call -- and
> because the i386 table is already a bit of an "odd man out". I would
> much rather like to see a setup where you have __SYSCALL() macros in
> unistd_64.h-style and perhaps augment it with a 3-operand __SYSCALL()
> macro for the case where compat and non-compat are different.
>
> What do you think?
Yes, that's certainly an alternative.
Jan
next prev parent reply other threads:[~2011-04-27 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 15:33 Jan Beulich
2011-04-27 15:41 ` H. Peter Anvin
2011-04-27 16:02 ` Jan Beulich [this message]
2011-04-27 16:40 ` Arnd Bergmann
2011-04-27 16:43 ` H. Peter Anvin
2011-04-28 12:35 ` Arnd Bergmann
2011-04-28 18:17 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB85A4F020000780003E6F7@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®