Re: [PATCH][RESEND] Fix EDD3.0 data verification.

["H. Peter Anvin" <hpa@zytor.com>]

On 04/27/2011 05:32 AM, Gleb Natapov wrote:
> 
> This patch is only fixes obviously incorrect code in edd_has_edd30()
> to do proper check instead of summing random memory and it should be
> applied even if we decide that we want to support Phoenix spec too.
> 
> I looked into implementing support for Phoenix spec back then when I
> wrote the patch and I decided against it. The main (and may be only)
> use case for edd module is to provide OS installer with enough info
> for it to decide where to install boot loader. Unfortunately Phoenix
> EDD spec does not support most modern storage technologies and even for
> legacy one such as ATA it does not provide enough info to determine boot
> disk correctly (you can't tell the difference between two ATA channels,
> T13 spec provides this info in interface path along with PCI address).
> So even if we would have support for it the OS installer will have to
> check if the information comes from T13 or Phoenix and ignore it if it's
> the later.
> 

I still think it would be a lot better to let userspace decide how it
wants to handle things, but oh well.

	-hpa