From: zhang warden <zhangwarden@gmail.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Miroslav Benes <mbenes@suse.cz>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Petr Mladek <pmladek@suse.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: introduce klp_func called interface
Date: Tue, 4 Jun 2024 16:14:51 +0800 [thread overview]
Message-ID: <4DE98E35-2D1F-4A4E-8689-35FD246606EF@gmail.com> (raw)
In-Reply-To: <Zloh/TbRFIX6UtA+@redhat.com>
> On Jun 1, 2024, at 03:16, Joe Lawrence <joe.lawrence@redhat.com> wrote:
>
> Adding these attributes to livepatch sysfs would be expedient and
> probably easier for us to use, but imposes a recurring burden on us to
> maintain and test (where is the documentation and kselftest for this new
> interface?). Or, we could let the other tools handle all of that for
> us.
How this attribute imposes a recurring burden to maintain and test?
> Perhaps if someone already has an off-the-shelf script that is using
> ftrace to monitor livepatched code, it could be donated to
> Documentation/livepatch/? I can ask our QE folks if they have something
> like this.
My intention to introduce this attitude to sysfs is that user who what to see if this function is called can just need to show this function attribute in the livepatch sysfs interface.
User who have no experience of using ftrace will have problems to get the calling state of the patched function. After all, ftrace is a professional kernel tracing tools.
Adding this attribute will be more easier for us to show if this patched function is called. Actually, I have never try to use ftrace to trace a patched function. Is it OK of using ftrace for a livepatched function?
Regards,
Wardenjohn
next prev parent reply other threads:[~2024-06-04 8:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 0:58 Wardenjohn
2024-05-20 6:46 ` Miroslav Benes
2024-05-20 7:10 ` zhang warden
2024-05-21 6:34 ` Miroslav Benes
2024-05-21 8:04 ` Petr Mladek
2024-05-24 8:09 ` zhang warden
2024-05-31 2:16 ` zhang warden
2024-05-31 7:21 ` Miroslav Benes
2024-05-31 13:19 ` zhang warden
2024-05-31 14:06 ` Miroslav Benes
2024-06-04 8:17 ` zhang warden
2024-06-05 5:04 ` Song Liu
2024-06-07 9:07 ` Miroslav Benes
2024-06-07 16:59 ` Song Liu
2024-06-11 2:23 ` zhang warden
2024-06-20 3:39 ` zhang warden
2024-06-20 9:31 ` Miroslav Benes
2024-05-31 19:16 ` Joe Lawrence
2024-06-04 8:14 ` zhang warden [this message]
2024-06-04 11:01 ` zhang warden
2024-06-04 14:37 ` Joe Lawrence
2024-06-05 2:38 ` zhang warden
2024-06-06 15:01 ` Joe Lawrence
2024-06-07 2:26 ` zhang warden
2024-05-20 8:00 ` Markus Elfring
2024-05-20 9:34 ` zhang warden
-- strict thread matches above, loose matches on Subject: below --
2024-05-19 7:43 Wardenjohn
2024-05-19 18:05 ` Markus Elfring
2024-05-19 23:42 ` zhang warden
2024-05-23 14:22 ` Dan Carpenter
2024-05-24 8:12 ` zhang warden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE98E35-2D1F-4A4E-8689-35FD246606EF@gmail.com \
--to=zhangwarden@gmail.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®