From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, Jesper Juhl <jj@chaosbits.net>,
LKML <linux-kernel@vger.kernel.org>,
trivial@kernel.org, linux-media@vger.kernel.org,
ceph-devel@vger.kernel.org, Sage Weil <sage@newdream.net>
Subject: Re: [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/
Date: Fri, 24 Jun 2011 10:29:14 -0300 [thread overview]
Message-ID: <4E04912A.4090305@infradead.org> (raw)
In-Reply-To: <BANLkTinXymR_2A2Mr+UbhK63s2xjtK=B=g@mail.gmail.com>
Em 24-06-2011 09:20, Devin Heitmueller escreveu:
>> Applications are certainly using it. I know this for a fact for the ivtv driver where
>> feature improvements are marked that way.
>>
>> Without more research on how this is used I am not comfortable with this.
>>
>> Regards,
>>
>> Hans
>
> MythTV has a bunch of these too (mainly so the code can adapt to
> driver bugs that are fixed in later revisions). Putting Mauro's patch
> upstream will definitely cause breakage.
It shouldn't, as ivtv driver version is lower than 3.0.0. All the old bug fixes
aren't needed if version is >= 3.0.0.
Besides that, trusting on a driver revision number to detect that a bug is
there is not the right thing to do, as version numbers are never increased at
the stable kernels (nor distro modified kernels take care of increasing revision
number as patches are backported there).
In other words, relying on it doesn't work fine.
> Also, it screws up the ability for users to get fixes through the
> media_build tree (unless you are increasing the revision constantly
> with every merge you do).
Why? Developers don't increase version numbers on every applied patch
(with is great, as it avoids merge conflicts).
Mauro
next prev parent reply other threads:[~2011-06-24 13:29 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 21:51 [PATCH 00/37] Remove unneeded version.h includes (and add where needed) Jesper Juhl
2011-06-23 21:54 ` [PATCH 01/37] Remove unneeded version.h includes from sound/ Jesper Juhl
2011-06-24 9:29 ` Takashi Iwai
2011-06-23 21:56 ` [PATCH 02/37] Remove unneeded version.h include from lib/ Jesper Juhl
2011-06-23 21:58 ` [PATCH 03/37] Remove unneeded version.h includes from include/ Jesper Juhl
2011-06-23 22:15 ` Sage Weil
2011-06-24 11:21 ` [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: " Mauro Carvalho Chehab
2011-06-24 11:26 ` Hans Verkuil
2011-06-24 12:20 ` Devin Heitmueller
2011-06-24 13:29 ` Mauro Carvalho Chehab [this message]
2011-06-24 13:45 ` Devin Heitmueller
2011-06-24 13:54 ` Hans Verkuil
2011-06-24 14:37 ` Mauro Carvalho Chehab
2011-06-24 18:25 ` [PATCH] [media] Stop using linux/version.h on most drivers Mauro Carvalho Chehab
2011-06-25 10:09 ` Hans Verkuil
2011-06-25 12:14 ` Mauro Carvalho Chehab
2011-06-27 0:59 ` Laurent Pinchart
2011-06-24 18:34 ` [RFC] Don't use linux/version.h anymore to indicate a per-driver version - Was: Re: [PATCH 03/37] Remove unneeded version.h includes from include/ Stefan Richter
2011-06-24 18:48 ` Devin Heitmueller
2011-06-24 21:04 ` Andy Walls
2011-06-24 21:20 ` Stefan Richter
2011-06-24 21:22 ` Devin Heitmueller
2011-06-24 21:49 ` Mauro Carvalho Chehab
2011-06-24 22:39 ` Stefan Richter
2011-06-24 23:02 ` Mauro Carvalho Chehab
2011-06-24 22:16 ` Mauro Carvalho Chehab
2011-06-24 22:57 ` Andy Walls
2011-06-24 21:10 ` Stefan Richter
2011-06-24 21:52 ` Mauro Carvalho Chehab
2011-06-24 21:44 ` Mauro Carvalho Chehab
2011-06-23 21:59 ` [PATCH 04/37] Remove unneeded version.h includes from fs/ Jesper Juhl
2011-06-24 13:26 ` Bob Copeland
2011-06-23 22:00 ` [PATCH 05/37] Remove unneeded version.h include from arch/x86/ Jesper Juhl
2011-06-23 22:07 ` [PATCH 06/37] Remove unneeded version.h includes from arch/mips/ Jesper Juhl
2011-08-02 10:22 ` Ralf Baechle
2011-06-23 22:08 ` [PATCH 07/37] Remove unneeded version.h includes from arch/arm/ Jesper Juhl
2011-06-23 23:01 ` Jiandong Zheng
2011-06-23 23:02 ` JD (Jiandong) Zheng
2011-06-23 22:09 ` [PATCH 08/37] Remove unneeded version.h includes from drivers/block/ Jesper Juhl
2011-06-23 22:10 ` [PATCH 09/37] Remove unneeded version.h includes from drivers/input/ Jesper Juhl
2011-06-23 22:50 ` Mike Frysinger
2011-06-27 7:10 ` Hennerich, Michael
2011-06-27 19:00 ` Dmitry Torokhov
2011-06-23 22:11 ` [PATCH 10/37] Remove unneeded version.h includes from drivers/media/dvb/ Jesper Juhl
2011-06-23 22:14 ` [PATCH 11/37] Remove unneeded version.h includes (and add where needed) for drivers/media/radio/ Jesper Juhl
2011-06-23 22:17 ` [PATCH 12/37] Remove unneeded version.h includes (and add where needed) for drivers/media/video/ Jesper Juhl
2011-06-24 8:52 ` Laurent Pinchart
2011-06-23 22:21 ` [PATCH 13/37] Remove unneeded version.h includes from drivers/net/ Jesper Juhl
2011-06-24 9:40 ` David Miller
2011-06-23 22:26 ` [PATCH 14/37] Remove unneeded version.h includes from drivers/scsi/ Jesper Juhl
2011-06-23 22:30 ` [PATCH 15/37] Remove unneeded version.h includes from drivers/target/ Jesper Juhl
2011-06-23 22:31 ` [PATCH 16/37] Remove unneeded version.h includes (and add where needed) for drivers/usb/ Jesper Juhl
2011-06-27 8:20 ` Felipe Balbi
2011-06-27 8:49 ` Laurent Pinchart
2011-06-23 22:32 ` [PATCH 17/37] Remove unneeded version.h include from drivers/uwb/ Jesper Juhl
2011-06-23 22:35 ` [PATCH 18/37] Remove unneeded version.h includes from drivers/video/ Jesper Juhl
2011-06-23 22:51 ` Mike Frysinger
2011-06-24 8:17 ` Paul Mundt
2011-06-23 22:40 ` [PATCH 19/37] Remove unneeded version.h includes from drivers/staging/rtl*/ Jesper Juhl
2011-06-23 23:57 ` Larry Finger
2011-06-23 22:41 ` [PATCH 20/37] Remove unneeded version.h includes from drivers/staging/gma500/ Jesper Juhl
2011-06-23 23:17 ` Alan Cox
2011-07-07 10:42 ` Alan Cox
2011-06-23 22:42 ` [PATCH 21/37] Remove unneeded version.h includes from drivers/staging/ath6kl/ Jesper Juhl
2011-06-23 22:43 ` [PATCH 22/37] Remove unneeded version.h include from drivers/staging/bcm/headers.h Jesper Juhl
2011-06-23 22:44 ` [PATCH 23/37] Remove unneeded version.h include from drivers/staging/cxd2099/cxd2099.c Jesper Juhl
2011-06-23 22:47 ` [PATCH 24/37] Remove unneeded version.h include from drivers/staging/cxt1e1/sbecom_inline_linux.h Jesper Juhl
2011-06-23 22:51 ` [PATCH 25/37] Remove unneeded version.h includes (and add where needed) for drivers/staging/easycap/ Jesper Juhl
2011-06-23 22:52 ` [PATCH 26/37] Remove unneeded version.h include from drivers/staging/hv/hv_timesource.c Jesper Juhl
2011-06-23 22:53 ` [PATCH 27/37] Remove unneeded version.h includes from drivers/staging/lirc/ Jesper Juhl
2011-06-23 22:54 ` [PATCH 28/37] Remove unneeded version.h include from drivers/staging/mei/main.c Jesper Juhl
2011-06-23 22:56 ` [PATCH 29/37] Remove unneeded version.h includes from drivers/staging/msm/ Jesper Juhl
2011-06-24 1:47 ` David Brown
2011-06-23 22:58 ` [PATCH 30/37] Remove unneeded version.h include from drivers/staging/panel/panel.c Jesper Juhl
2011-06-23 23:00 ` [PATCH 31/37] Remove unneeded version.h include from drivers/staging/rts_pstor/rtsx.h Jesper Juhl
2011-06-23 23:01 ` [PATCH 32/37] Remove unneeded version.h includes from drivers/staging/speakup/ Jesper Juhl
2011-06-23 23:02 ` [PATCH 33/37] Remove unneeded version.h include from drivers/staging/tidspbridge/include/dspbridge/host_os.h Jesper Juhl
2011-06-23 23:04 ` [PATCH 34/37] Remove unneeded version.h includes (and add where needed) for drivers/tm6000/ Jesper Juhl
2011-06-23 23:05 ` [PATCH 35/37] Remove unneeded version.h includes from drivers/staging/wlags49_h2/ Jesper Juhl
2011-06-23 23:06 ` [PATCH 36/37] Remove unneeded version.h include from drivers/staging/wlan-ng/prism2sta.c Jesper Juhl
2011-06-23 23:08 ` [PATCH 37/37] Remove unneeded version.h includes from drivers/staging/xgifb/ Jesper Juhl
2011-06-24 9:13 ` [PATCH 00/37] Remove unneeded version.h includes (and add where needed) Jiri Kosina
2011-06-24 10:48 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E04912A.4090305@infradead.org \
--to=mchehab@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dheitmueller@kernellabs.com \
--cc=hverkuil@xs4all.nl \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sage@newdream.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome